Skip to content

fix advection#581

Merged
GiovanniCanali merged 1 commit into
mathLab:devfrom
GiovanniCanali:advection
May 29, 2025
Merged

fix advection#581
GiovanniCanali merged 1 commit into
mathLab:devfrom
GiovanniCanali:advection

Conversation

@GiovanniCanali
Copy link
Copy Markdown
Collaborator

@GiovanniCanali GiovanniCanali commented May 29, 2025 •
edited
Loading

Description

This PR fixes #578

Checklist

  • Code follows the project’s Code Style Guidelines
  • Tests have been added or updated
  • Documentation has been updated if necessary
  • Pull request is linked to an open issue

@GiovanniCanali GiovanniCanali self-assigned this May 29, 2025
@GiovanniCanali GiovanniCanali added the pr-to-fix Label for PR that needs modification label May 29, 2025
@GiovanniCanali GiovanniCanali linked an issue May 29, 2025 that may be closed by this pull request
Advection operator no longer accepts multi-variable velocity field #578
Closed
@GiovanniCanali GiovanniCanali added pr-to-review Label for PR that are ready to been reviewed and removed pr-to-fix Label for PR that needs modification labels May 29, 2025
@GiovanniCanali
Copy link
Copy Markdown
Collaborator Author

GiovanniCanali commented May 29, 2025 •
edited
Loading

Hi @dario-coscia , @FilippoOlivo!
In addition to fixing the issue with the velocity field, I have written a broader test for advection. Also, now advection returns a LabelTensor, whose labels are adv + label of the transported component. This was done to maintain a standard among all operators.

ex: if I want to transport field f via velocity u, the label will be adv_f.

dario-coscia
dario-coscia approved these changes May 29, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@dario-coscia dario-coscia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super!

@GiovanniCanali GiovanniCanali merged commit 254ec8e into mathLab:dev May 29, 2025
18 of 19 checks passed
@GiovanniCanali GiovanniCanali deleted the advection branch May 29, 2025 12:34
dario-coscia added a commit that referenced this pull request Jun 13, 2025
@dario-coscia @FilippoOlivo
@GiovanniCanali @AleDinve
Dev Update (#582)
7bf7d34 
* Fix adaptive refinement (#571)


---------

Co-authored-by: Dario Coscia <93731561+dario-coscia@users.noreply.github.com>

* Remove collector

* Fixes

* Fixes

* rm unnecessary comment

* fix advection (#581)

* Fix tutorial .html link (#580)

* fix problem data collection for v0.1 (#584)

* Message Passing Module (#516)

* add deep tensor network block

* add interaction network block

* add radial field network block

* add schnet block

* add equivariant network block

* fix + tests + doc files

* fix egnn + equivariance/invariance tests

Co-authored-by: Dario Coscia <dariocos99@gmail.com>

---------

Co-authored-by: giovanni <giovanni.canali98@yahoo.it>
Co-authored-by: AleDinve <giuseppealessio.d@student.unisi.it>

* add type checker (#527)

---------

Co-authored-by: Filippo Olivo <filippo@filippoolivo.com>
Co-authored-by: Giovanni Canali <115086358+GiovanniCanali@users.noreply.github.com>
Co-authored-by: giovanni <giovanni.canali98@yahoo.it>
Co-authored-by: AleDinve <giuseppealessio.d@student.unisi.it>
GiovanniCanali added a commit to GiovanniCanali/PINA that referenced this pull request Dec 2, 2025
@dario-coscia @FilippoOlivo
@GiovanniCanali @AleDinve
Dev Update (mathLab#582)
bbc0257 
* Fix adaptive refinement (mathLab#571)


---------

Co-authored-by: Dario Coscia <93731561+dario-coscia@users.noreply.github.com>

* Remove collector

* Fixes

* Fixes

* rm unnecessary comment

* fix advection (mathLab#581)

* Fix tutorial .html link (mathLab#580)

* fix problem data collection for v0.1 (mathLab#584)

* Message Passing Module (mathLab#516)

* add deep tensor network block

* add interaction network block

* add radial field network block

* add schnet block

* add equivariant network block

* fix + tests + doc files

* fix egnn + equivariance/invariance tests

Co-authored-by: Dario Coscia <dariocos99@gmail.com>

---------

Co-authored-by: giovanni <giovanni.canali98@yahoo.it>
Co-authored-by: AleDinve <giuseppealessio.d@student.unisi.it>

* add type checker (mathLab#527)

---------

Co-authored-by: Filippo Olivo <filippo@filippoolivo.com>
Co-authored-by: Giovanni Canali <115086358+GiovanniCanali@users.noreply.github.com>
Co-authored-by: giovanni <giovanni.canali98@yahoo.it>
Co-authored-by: AleDinve <giuseppealessio.d@student.unisi.it>
GiovanniCanali added a commit to GiovanniCanali/PINA that referenced this pull request Dec 2, 2025
@dario-coscia @FilippoOlivo
@GiovanniCanali @AleDinve
Dev Update (mathLab#582)
e16e29b 
* Fix adaptive refinement (mathLab#571)


---------

Co-authored-by: Dario Coscia <93731561+dario-coscia@users.noreply.github.com>

* Remove collector

* Fixes

* Fixes

* rm unnecessary comment

* fix advection (mathLab#581)

* Fix tutorial .html link (mathLab#580)

* fix problem data collection for v0.1 (mathLab#584)

* Message Passing Module (mathLab#516)

* add deep tensor network block

* add interaction network block

* add radial field network block

* add schnet block

* add equivariant network block

* fix + tests + doc files

* fix egnn + equivariance/invariance tests

Co-authored-by: Dario Coscia <dariocos99@gmail.com>

---------

Co-authored-by: giovanni <giovanni.canali98@yahoo.it>
Co-authored-by: AleDinve <giuseppealessio.d@student.unisi.it>

* add type checker (mathLab#527)

---------

Co-authored-by: Filippo Olivo <filippo@filippoolivo.com>
Co-authored-by: Giovanni Canali <115086358+GiovanniCanali@users.noreply.github.com>
Co-authored-by: giovanni <giovanni.canali98@yahoo.it>
Co-authored-by: AleDinve <giuseppealessio.d@student.unisi.it>
GiovanniCanali added a commit to GiovanniCanali/PINA that referenced this pull request Dec 2, 2025
@dario-coscia @FilippoOlivo
@GiovanniCanali @AleDinve
Dev Update (mathLab#582)
184e551 
* Fix adaptive refinement (mathLab#571)


---------

Co-authored-by: Dario Coscia <93731561+dario-coscia@users.noreply.github.com>

* Remove collector

* Fixes

* Fixes

* rm unnecessary comment

* fix advection (mathLab#581)

* Fix tutorial .html link (mathLab#580)

* fix problem data collection for v0.1 (mathLab#584)

* Message Passing Module (mathLab#516)

* add deep tensor network block

* add interaction network block

* add radial field network block

* add schnet block

* add equivariant network block

* fix + tests + doc files

* fix egnn + equivariance/invariance tests

Co-authored-by: Dario Coscia <dariocos99@gmail.com>

---------

Co-authored-by: giovanni <giovanni.canali98@yahoo.it>
Co-authored-by: AleDinve <giuseppealessio.d@student.unisi.it>

* add type checker (mathLab#527)

---------

Co-authored-by: Filippo Olivo <filippo@filippoolivo.com>
Co-authored-by: Giovanni Canali <115086358+GiovanniCanali@users.noreply.github.com>
Co-authored-by: giovanni <giovanni.canali98@yahoo.it>
Co-authored-by: AleDinve <giuseppealessio.d@student.unisi.it>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dario-coscia dario-coscia dario-coscia approved these changes

+1 more reviewer

@FilippoOlivo FilippoOlivo FilippoOlivo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@GiovanniCanali GiovanniCanali

Labels

pr-to-review Label for PR that are ready to been reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Advection operator no longer accepts multi-variable velocity field

3 participants

@GiovanniCanali @dario-coscia @FilippoOlivo