Support batching for rbapinns#589
Conversation
dario-coscia
left a comment
There was a problem hiding this comment.
I think the logic for batching weights is very clean, this actually solves the problem nicely!
I put some consideration on the code, I am wondering about future maintainability, I think we can clean it more
Hi @dario-coscia, thank you for your insightful review. Please, see the comments attached to your suggestions. I understand the proposed My suggestion is to discuss in the near future a reorganization of the whole logic behind the PINN-based solvers. Nothing would change under the user's perspective. |
52a73c1 to
e91264f
Compare
Description
This PR fixes #588
In this PR, I have added the support for batching while using
RBAPINNsolver class.Checklist