Add batching support for self-adaptive pinns#606
Merged
GiovanniCanali merged 1 commit intoJul 25, 2025
Conversation
GiovanniCanali
added
enhancement
GiovanniCanali
force-pushed
the
fix_self_adaptive_pinn
branch
from
882d32e to
e505ea1
Compare
GiovanniCanali
requested review from
FilippoOlivo and
dario-coscia
and removed request for
FilippoOlivo
GiovanniCanali
added
pr-to-review
dario-coscia
approved these changes
Jul 25, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR adds batching support for self-adaptive PINNs by removing the previous restriction that required full batch processing and implementing proper batch handling with self-adaptive weights.
Key changes:
- Remove the batch size restriction that previously threw NotImplementedError
- Implement proper batch indexing for self-adaptive weights using modulus operations
- Refactor loss computation to support batched operations with per-point weight application
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| tests/test_solver/test_self_adaptive_pinn.py | Remove test for batch restriction and add loss function parameterization to existing tests |
| pina/solver/physics_informed_solver/self_adaptive_pinn.py | Major refactor to support batching with proper weight indexing and loss computation |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #605
Checklist