Skip to content

Commit 82b88a7

Browse files
committed
docs: update CHANGELOG.md with complete Fix 8 details
1 parent 1b9c773 commit 82b88a7

1 file changed

Lines changed: 14 additions & 4 deletions

File tree

CHANGELOG.md

Lines changed: 14 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -145,21 +145,31 @@ Neither of these are valid configuration. They appear to be leftover debugging c
145145

146146
---
147147

148-
## Fix 8 — Fix CSS Nesting PostCSS Warning
148+
## Fix 8 — Fix CSS Nesting Warning and Remaining ESLint Warnings
149149

150150
**Branch:** `fix/8-css-nesting`
151151
**Date:** 2026-04-07
152-
**Tech:** PostCSS, Tailwind CSS `@layer` nesting, `postcss-nesting`
152+
**Tech:** PostCSS, `postcss-nesting`, ESLint (`no-unused-vars`, `array-callback-return`)
153153

154154
### Reason
155-
The build emits: `Nested CSS was detected, but CSS nesting has not been configured correctly. Please enable a CSS nesting plugin *before* Tailwind in your configuration.`
155+
Multiple remaining build warnings were identified and resolved:
156156

157-
This occurs because `index.css` uses `@layer base { ... }` with nested CSS rules, which requires a PostCSS nesting plugin (`postcss-nesting`) registered *before* the `tailwindcss` plugin. Without it, nested rules may not compile correctly in all environments.
157+
1. **CSS nesting warning** — The build emitted: `Nested CSS was detected, but CSS nesting has not been configured correctly.` Root cause was `.banner { hr { ... } }` in `src/pages/pages.css` — invalid CSS nesting without `&` selector. Fixed by un-nesting the rule into flat CSS (`.banner hr { ... }`). Also installed `postcss-nesting` plugin and registered it before `tailwindcss` in PostCSS config as belt-and-suspenders.
158+
159+
2. **`TailwindTable.js` unused variables**`let d = link[0].codeWarsLink`, `let i = data.id`, and `let e = [c, i].join("")` were assigned but never referenced in rendering. Variable `c` (leetCodeLink) is used; the others were dead code likely left from debugging.
160+
161+
3. **`DSA.jsx` missing map return**`cards.map((index) => { <Grid .../> })` used a block body `{}` with no `return` statement, so the mapped JSX was silently discarded. Fixed by adding explicit `return`.
162+
163+
4. **`DevelopersLibrary.jsx` unused state setter**`const [showFELinks, setShowFELinks] = useState(false)``setShowFELinks` was never called. `showFELinks` is still used in the JSX; removed the unused setter from the destructuring.
158164

159165
### Files Changed
160166

161167
- **`postcss.config.js`** — Added `postcss-nesting` plugin before `tailwindcss`
162168
- **`package.json`** — Added `postcss-nesting` as a dev dependency
169+
- **`src/pages/pages.css`** — Un-nested `.banner hr {}` from inside `.banner {}` to flat CSS
170+
- **`src/components/TailwindTable/TailwindTable.js`** — Removed unused variables `d`, `i`, `e`
171+
- **`src/pages/DSA.jsx`** — Added `return` statement to `cards.map()` arrow function body
172+
- **`src/pages/DevelopersLibrary.jsx`** — Removed unused `setShowFELinks` from useState destructuring
163173

164174
---
165175

0 commit comments

Comments
 (0)