Add publishing action#1274
Conversation
dpvc
left a comment
There was a problem hiding this comment.
Should the .travis.yaml file be removed with this PR? I'm not sure how that is hooked in. I think there is a setting that should be removed for the repository as well.
I also was wondering about whether the tests need to be run here, but I guess if they are run on all the PRs, they don't have to be done here.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1274 +/- ##
==========================================
Coverage 86.68% 86.68%
==========================================
Files 337 337
Lines 84105 84105
Branches 3125 4750 +1625
==========================================
Hits 72909 72909
Misses 11196 11196 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zorkow
left a comment
There was a problem hiding this comment.
I've done the changes and it runs locally with act. Yet to be tested is the publish job.
I had forgotten to remove the
Tests will run for every PR to |
This PR
test.js.ymltotest.ymlas thejsbit does not make any sense!I have tested the publishing action for the build. I need an
npmauthentication token for the final step.