Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1276 +/- ##
========================================
Coverage 86.68% 86.69%
========================================
Files 337 337
Lines 84105 84110 +5
Branches 4750 4752 +2
========================================
+ Hits 72909 72917 +8
+ Misses 11173 11170 -3
Partials 23 23 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a problem with building the
ui/menucomponent. Thecomponents/bin/buildcommand is modified to handleexport async functionwhich was causing an error during the build phase. Thets/a11y/sre.tsfunction also was causing problems when webpacking theui/menucomponent. The the SRE functions for the preferences were not being found by webpack for some reason that I could not fully determine. I don't see anything wrong in any of the files, but it seems to be connected to the directexportof those methods ints/a11y/res.ts, so I've change those to an import followed by exports, which seems to do the trick.In addition, I've added a generic highlighter in
ts/a11y/explorer/Highlighter.tsso that it can work in the absense of an output jax (I have an example in the documentation of a a role-you-own output jax for native MathML that causes an error otherwise).I also add a new named
STATEvalue ints/handler/html/HTMLDocument.tsjust for convenience, and so that all the default render actions have a named state value.