Fix incorrect removal of braces in template macros#1278
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1278 +/- ##
===========================================
- Coverage 86.68% 86.68% -0.01%
===========================================
Files 337 337
Lines 84105 84102 -3
Branches 4750 3125 -1625
===========================================
- Hits 72909 72906 -3
- Misses 11173 11196 +23
+ Partials 23 0 -23 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a problem with parsing the arguments of a macro with template where braces could be removed incorrectly. For example, with
\def\text#1\stop{#1}, if used with\text{a}{b}\stop, you currently will get an error about missing open braces. That is because the parameter#1will end up containinga}{brather than{a}{b}as expected.The solution is to set
hasBracesto false when a second braced argument is used. I also changedhasBracesto a boolean rather than a number.Two new tests are added to check for this issue. There should probably be some more tests for when
hasBracesgets unset, for completeness.