Skip to content

Fix problem with MathJax reference in liteDOM#1280

Merged
dpvc merged 1 commit into
developfrom
fix/liteDOM
Jun 20, 2025
Merged

Fix problem with MathJax reference in liteDOM#1280
dpvc merged 1 commit into
developfrom
fix/liteDOM

Conversation

@dpvc
Copy link
Copy Markdown
Member

@dpvc dpvc commented Jun 19, 2025

This PR fixes a problem with the changes in b7f1942 that cause an error in node applications that use direct loading of the MathJax modules, where the MathJax variable is not defined. I thought the MathJax?.loader would check for that, but it turns out that isn't the case, and a more explicit check for being defined is needed.

@dpvc dpvc requested a review from zorkow June 19, 2025 19:05
@dpvc dpvc added this to the v4.0 milestone Jun 19, 2025
@dpvc
Copy link
Copy Markdown
Member Author

dpvc commented Jun 19, 2025

This was part of my testing to see that wicked-good-expath is not needed in node applications that use SRE, and with this fix, everything looks good to remove that dependency.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 19, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 86.68%. Comparing base (351698e) to head (15aa49a).
Report is 6 commits behind head on develop.

Files with missing lines Patch % Lines
ts/adaptors/lite/Element.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1280   +/-   ##
========================================
  Coverage    86.68%   86.68%           
========================================
  Files          337      337           
  Lines        84105    84105           
  Branches      4750     4750           
========================================
  Hits         72909    72909           
  Misses       11173    11173           
  Partials        23       23           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@zorkow zorkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, although the tests are complaining about the new line not being covered.

@dpvc
Copy link
Copy Markdown
Member Author

dpvc commented Jun 20, 2025

the tests are complaining about the new line not being covered.

That file never had complete coverage. We only have complete coverage for the TeX input jax and the ts/util folder. Everything else still needs work.

@dpvc dpvc merged commit 4b42301 into develop Jun 20, 2025
2 of 3 checks passed
@dpvc dpvc deleted the fix/liteDOM branch June 20, 2025 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants