Fix problem with MathJax reference in liteDOM#1280
Conversation
|
This was part of my testing to see that wicked-good-expath is not needed in node applications that use SRE, and with this fix, everything looks good to remove that dependency. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1280 +/- ##
========================================
Coverage 86.68% 86.68%
========================================
Files 337 337
Lines 84105 84105
Branches 4750 4750
========================================
Hits 72909 72909
Misses 11173 11173
Partials 23 23 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zorkow
left a comment
There was a problem hiding this comment.
looks good, although the tests are complaining about the new line not being covered.
That file never had complete coverage. We only have complete coverage for the TeX input jax and the |
This PR fixes a problem with the changes in b7f1942 that cause an error in node applications that use direct loading of the MathJax modules, where the
MathJaxvariable is not defined. I thought theMathJax?.loaderwould check for that, but it turns out that isn't the case, and a more explicit check for being defined is needed.