Skip to content

Make sure AsciiMath text elements are of kind #text#1306

Merged
dpvc merged 1 commit into
developfrom
fix/asciimath-text
Jul 18, 2025
Merged

Make sure AsciiMath text elements are of kind #text#1306
dpvc merged 1 commit into
developfrom
fix/asciimath-text

Conversation

@dpvc
Copy link
Copy Markdown
Member

@dpvc dpvc commented Jul 14, 2025

This makes the legacy AsciiMath internal format to v3/v4 internal format properly mark the text elements as #text rather than text.

@dpvc dpvc requested a review from zorkow July 14, 2025 14:49
@dpvc dpvc added this to the v4.0 milestone Jul 14, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.71%. Comparing base (4d1e195) to head (f6bac7c).
Report is 36 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff             @@
##           develop    #1306     +/-   ##
==========================================
  Coverage    86.71%   86.71%             
==========================================
  Files          337      337             
  Lines        83979    83979             
  Branches      4750     3124   -1626     
==========================================
  Hits         72826    72826             
- Misses       11130    11153     +23     
+ Partials        23        0     -23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@zorkow zorkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@dpvc dpvc merged commit ae6aef4 into develop Jul 18, 2025
3 checks passed
@dpvc dpvc deleted the fix/asciimath-text branch July 18, 2025 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants