Move toEntry to be a method so that it can be override, if necessary#1307
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1307 +/- ##
===========================================
- Coverage 86.71% 86.70% -0.02%
===========================================
Files 337 337
Lines 83979 84021 +42
Branches 4750 4752 +2
===========================================
+ Hits 72826 72853 +27
- Misses 11130 11168 +38
+ Partials 23 0 -23 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zorkow
requested changes
Jul 18, 2025
Member
zorkow
left a comment
There was a problem hiding this comment.
Could you then also remove the function in line 29/30? Or is that the one you need to have in the demos?
Member
Author
|
It could be removed if the definition is moved to the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves the
toEntry()call to a method so that it can be overridden if subclassed (I need the in one of the examples in the demos-node update).