Skip to content

Move toEntry to be a method so that it can be override, if necessary#1307

Merged
dpvc merged 2 commits into
developfrom
update/mml-visitor
Jul 28, 2025
Merged

Move toEntry to be a method so that it can be override, if necessary#1307
dpvc merged 2 commits into
developfrom
update/mml-visitor

Conversation

@dpvc
Copy link
Copy Markdown
Member

@dpvc dpvc commented Jul 14, 2025

This PR moves the toEntry() call to a method so that it can be overridden if subclassed (I need the in one of the examples in the demos-node update).

@dpvc dpvc requested a review from zorkow July 14, 2025 14:51
@dpvc dpvc added this to the v4.0 milestone Jul 14, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.70%. Comparing base (4d1e195) to head (0f7dd5d).
⚠️ Report is 53 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1307      +/-   ##
===========================================
- Coverage    86.71%   86.70%   -0.02%     
===========================================
  Files          337      337              
  Lines        83979    84021      +42     
  Branches      4750     4752       +2     
===========================================
+ Hits         72826    72853      +27     
- Misses       11130    11168      +38     
+ Partials        23        0      -23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@zorkow zorkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you then also remove the function in line 29/30? Or is that the one you need to have in the demos?

@dpvc
Copy link
Copy Markdown
Member Author

dpvc commented Jul 18, 2025

It could be removed if the definition is moved to the toEntry() method instead. But it seemed like a potentially useful function, so I left it exported. But I suppose it could be moved to ts/util/string.ts instead. I'll make another commit to do that.

@dpvc dpvc requested a review from zorkow July 23, 2025 09:13
Copy link
Copy Markdown
Member

@zorkow zorkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@dpvc dpvc merged commit 9ffe6d5 into develop Jul 28, 2025
2 of 3 checks passed
@dpvc dpvc deleted the update/mml-visitor branch July 28, 2025 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants