Skip to content

Check that enrichment is enabled before starting webworker#1311

Merged
dpvc merged 2 commits into
developfrom
update/no-enrichment
Jul 18, 2025
Merged

Check that enrichment is enabled before starting webworker#1311
dpvc merged 2 commits into
developfrom
update/no-enrichment

Conversation

@dpvc
Copy link
Copy Markdown
Member

@dpvc dpvc commented Jul 16, 2025

This PR makes sure that enrichment is being performed before trying to add speech or Braille. This avoids an error in node applications that load a combined configuration with speech, but turn off enrichment while leaving the speech or Braille defaults (which are on).

@dpvc dpvc requested a review from zorkow July 16, 2025 15:34
@dpvc dpvc added this to the v4.0 milestone Jul 16, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.71%. Comparing base (4d1e195) to head (2c15c61).
Report is 43 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff             @@
##           develop    #1311     +/-   ##
==========================================
  Coverage    86.71%   86.71%             
==========================================
  Files          337      337             
  Lines        83979    83979             
  Branches      4750     3124   -1626     
==========================================
  Hits         72826    72826             
- Misses       11130    11153     +23     
+ Partials        23        0     -23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@zorkow zorkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@dpvc dpvc merged commit bc7a4ac into develop Jul 18, 2025
3 checks passed
@dpvc dpvc deleted the update/no-enrichment branch July 18, 2025 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants