Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1397 +/- ##
===========================================
- Coverage 86.49% 86.49% -0.01%
===========================================
Files 340 340
Lines 85813 85811 -2
Branches 3177 4815 +1638
===========================================
- Hits 74220 74218 -2
+ Misses 11593 11570 -23
- Partials 0 23 +23 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zorkow
left a comment
There was a problem hiding this comment.
My only question is: Do we not also need a node-main.mjs for ESM?
|
You are probably right, both versions should be able to use |
|
It turns out that yes, we do need the mjs version. There are two reasons: one is that when The other reason is to get the exports correct; the mjs file exports both So I think it is better to leave it as is rather than try to eliminate this one small file. |
This PR changes
node-main-setup.mjsto benode-main-setup.cjsso that the import order is respected in thebunenvironment (works around what I think is a bug inbun).This doesn' have to go into 4.1, but it is pretty straight-forward, so perhaps we can squeeze it in.
Resolves issue mathjax/MathJax#3476.