Skip to content

Make sure output renderer settings are transferred when the menu selects a new renderer. #1435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dpvc merged 1 commit into from
Feb 19, 2026
Merged

Make sure output renderer settings are transferred when the menu selects a new renderer. #1435

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 20 additions & 7 deletions ts/ui/menu/Menu.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1087,12 +1087,7 @@ export class Menu {
this.settings.renderer.replace(/[^a-zA-Z0-9]/g, '') || 'CHTML';
(Menu._loadingPromise || Promise.resolve()).then(() => {
const settings = this.settings;
const options = this.document.outputJax.options;
options.scale = parseFloat(settings.scale);
options.displayOverflow = settings.overflow.toLowerCase();
if (options.linebreaks) {
options.linebreaks.inline = settings.breakInline;
}
this.applyRendererOptions(this.document.outputJax);
if (!settings.speechRules) {
const sre = this.document.options.sre;
settings.speechRules = `${sre.domain || 'clearspeak'}-${sre.style || 'default'}`;
Expand Down Expand Up @@ -1143,6 +1138,7 @@ export class Menu {
*/
protected setRenderer(jax: string, rerender: boolean = true): Promise<void> {
if (Object.hasOwn(this.jax, jax) && this.jax[jax]) {
this.applyRendererOptions(this.jax[jax]);
return this.setOutputJax(jax, rerender);
}
const name = jax.toLowerCase();
Expand All @@ -1153,7 +1149,7 @@ export class Menu {
return fail(new Error(`Component ${name} not loaded`));
}
startup.useOutput(name, true);
startup.output = startup.getOutputJax();
startup.output = this.applyRendererOptions(startup.getOutputJax());
startup.output.setAdaptor(this.document.adaptor);
startup.output.initialize();
this.jax[jax] = startup.output;
Expand All @@ -1164,6 +1160,23 @@ export class Menu {
});
}

/**
* @param {OutputJax<HTMLElement, Text, Document>} output The output jax to adjust.
* @returns {OutputJax<HTMLElement, Text, Document>} The adjusted output jax.
*/
protected applyRendererOptions(
output: OutputJax<HTMLElement, Text, Document>
): OutputJax<HTMLElement, Text, Document> {
const settings = this.settings;
const options = output.options;
options.scale = parseFloat(settings.scale);
options.displayOverflow = settings.overflow.toLowerCase();
if (options.linebreaks) {
options.linebreaks.inline = settings.breakInline;
}
return output;
}

/**
* Set up the new jax and link it to the document,
* load any needed extensions, and then rerender the math, if needed
Expand Down