Skip to content

Introduce linting and formatting on testsuite#1447

Merged
zorkow merged 7 commits intodevelopfrom
tests/linting
Mar 24, 2026
Merged

Introduce linting and formatting on testsuite#1447
zorkow merged 7 commits intodevelopfrom
tests/linting

Conversation

@zorkow
Copy link
Copy Markdown
Member

@zorkow zorkow commented Mar 23, 2026

PR introduces formatting and linting on the testsuite. In particular, it

  • adapts the configuration to include the testsuite (details below)
  • reformats the code according to prettier
  • does all the automatic linting (mainly let to const)
  • adds some of the missing jsdoc in the test sources
  • manually fixes a number of linting issues (see last commit for details)

There are still four lint errors left of the type no-useless-escape. These seem to be LaTeX errors, which have an effect on the actual test output. I'll take care of those in a separate PR.

Configuration and Setup Changes

‎* Introduces pnpm-workspace.yaml file so we can refer to scripts in the workspace root from internal packages.

  • Adds linting and formatting scripts to the package.json in testsuite that calls the respective workspace scripts.
  • Relaxes file restrictions in eslint.config.mjs
  • Adds a second eslint configuration to switch off jsdoc rules for *.test.ts files. This unfortunately leads to a reformatting. But that is all just whitspace.

@zorkow zorkow requested a review from dpvc March 23, 2026 15:02
@zorkow zorkow changed the title Tests/linting Introduce linting and formatting on testsuite Mar 23, 2026
Copy link
Copy Markdown
Member

@dpvc dpvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Two comments about a strange use of |.

As for the four lint errors, they are all actual errors.

The first one in Base.test.ts should have one of the \ removed (should only be \\end not \\\end), and the second one needs an extra \ (so that it is \\cdot).

The \$ in Bussproofs.test.ts should just be $.

The \\\end should be \\end again in Newcommand.test.ts.

Base automatically changed from tests/cleanup_separators to develop March 24, 2026 12:24
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.49%. Comparing base (bd27399) to head (8ca5247).
⚠️ Report is 9 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1447   +/-   ##
========================================
  Coverage    86.49%   86.49%           
========================================
  Files          340      340           
  Lines        86044    86044           
  Branches      4833     4833           
========================================
  Hits         74425    74425           
  Misses       11595    11595           
  Partials        24       24           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zorkow
Copy link
Copy Markdown
Member Author

zorkow commented Mar 24, 2026

Also needed to push a new version of pnpm-lock.yaml after running pnpm install. The old version made the tests fail.

@zorkow zorkow merged commit da32350 into develop Mar 24, 2026
3 checks passed
@zorkow zorkow deleted the tests/linting branch March 24, 2026 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants