Introduce linting and formatting on testsuite#1447
Conversation
dpvc
left a comment
There was a problem hiding this comment.
Looks good. Two comments about a strange use of |.
As for the four lint errors, they are all actual errors.
The first one in Base.test.ts should have one of the \ removed (should only be \\end not \\\end), and the second one needs an extra \ (so that it is \\cdot).
The \$ in Bussproofs.test.ts should just be $.
The \\\end should be \\end again in Newcommand.test.ts.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1447 +/- ##
========================================
Coverage 86.49% 86.49%
========================================
Files 340 340
Lines 86044 86044
Branches 4833 4833
========================================
Hits 74425 74425
Misses 11595 11595
Partials 24 24 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Also needed to push a new version of |
PR introduces formatting and linting on the testsuite. In particular, it
testsuite(details below)prettierlettoconst)There are still four lint errors left of the type
no-useless-escape. These seem to be LaTeX errors, which have an effect on the actual test output. I'll take care of those in a separate PR.Configuration and Setup Changes
* Introduces
pnpm-workspace.yamlfile so we can refer to scripts in the workspace root from internal packages.package.jsonintestsuitethat calls the respective workspace scripts.eslint.config.mjseslintconfiguration to switch off jsdoc rules for*.test.tsfiles. This unfortunately leads to a reformatting. But that is all just whitspace.