Migrate remaining Sinon mocks to Vitest (mozilla#3885)

Author: nishitmistry

package-lock.json

@@ -63,7 +63,6 @@
     "@types/react-tabs": "^2.3.4",
     "@types/reactour": "^1.18.1",
     "@types/shortid": "^0.0.29",
-    "@types/sinon": "^10.0.1",
     "@types/styled-components": "^5.1.9",
     "@typescript-eslint/eslint-plugin": "^8.7.0",
     "@typescript-eslint/parser": "^8.7.0",
@@ -82,7 +81,6 @@
     "react-intersection-observer": "9.11.0",
     "rollup": "^3.29.5",
     "rollup-plugin-css-only": "^4.3.0",
-    "sinon": "^13.0.2",
     "typescript": "^5.8.3",
     "utility-types": "^3.10.0",
     "vitest": "^4.0.9"

package.json

@@ -259,7 +259,6 @@ At this stage, only the translation workspace is localizable. Until the full app
 - [Redux](https://redux.js.org/)
 - [create-react-app](https://github.com/facebook/create-react-app/blob/master/packages/react-scripts/template/README.md)
 - [Vitest](https://vitest.dev/guide/#getting-started)
-- [sinon](https://sinonjs.org/releases/v6.0.0/)
 - [Linkify](https://tasti.github.io/react-linkify/)
 - [ReactTimeAgo](https://github.com/catamphetamine/react-time-ago)
 - [react-tabs](https://github.com/reactjs/react-tabs)

translate/README.md

@@ -25,7 +25,7 @@ describe('usePluralExamples', () => {
     });
 
     expect(res).toEqual({ 1: 1, 2: 2, 3: 3, 5: 0 });
-    expect(consoleErrorSpy).toHaveBeenCalledTimes(0);
+    expect(consoleErrorSpy).not.toHaveBeenCalled();
   });
 
   it('prevents infinite loop if locale plurals are not configured properly', () => {
@@ -36,6 +36,6 @@ describe('usePluralExamples', () => {
     });
 
     expect(res).toEqual({ 0: 1, 1: 2 });
-    expect(consoleErrorSpy).toHaveBeenCalledTimes(1);
+    expect(consoleErrorSpy).toHaveBeenCalledOnce();
   });
 });

translate/src/hooks/usePluralExamples.test.js

@@ -1,10 +1,10 @@
 import React from 'react';
 import { mount } from 'enzyme';
-import sinon from 'sinon';
 
 import { MockLocalizationProvider } from '~/test/utils';
 
 import { ApproveAll } from './ApproveAll';
+import { vi } from 'vitest';
 
 const DEFAULT_BATCH_ACTIONS = {
   entities: [],
@@ -98,7 +98,7 @@ describe('<ApproveAll>', () => {
   });
 
   it('performs approve all action when Approve All button is clicked', () => {
-    const mockApproveAll = sinon.spy();
+    const mockApproveAll = vi.fn();
 
     const wrapper = mount(
       <WrapApproveAll
@@ -107,8 +107,8 @@ describe('<ApproveAll>', () => {
       />,
     );
 
-    expect(mockApproveAll.called).toBeFalsy();
+    expect(mockApproveAll).not.toHaveBeenCalled();
     wrapper.find('.approve-all').simulate('click');
-    expect(mockApproveAll.called).toBeTruthy();
+    expect(mockApproveAll).toHaveBeenCalled();
   });
 });

translate/src/modules/batchactions/components/ApproveAll.test.jsx

@@ -1,10 +1,10 @@
 import { mount } from 'enzyme';
 import React from 'react';
-import sinon from 'sinon';
 
 import { MockLocalizationProvider } from '~/test/utils';
 
 import { RejectAll } from './RejectAll';
+import { vi } from 'vitest';
 
 const DEFAULT_BATCH_ACTIONS = {
   entities: [],
@@ -98,7 +98,7 @@ describe('<RejectAll>', () => {
   });
 
   it('raise confirmation warning when Reject All button is clicked', () => {
-    const mockRejectAll = sinon.spy();
+    const mockRejectAll = vi.fn();
 
     const wrapper = mount(
       <WrapRejectAll
@@ -107,16 +107,15 @@ describe('<RejectAll>', () => {
       />,
     );
 
-    expect(mockRejectAll.called).toBeFalsy();
     wrapper.find('.reject-all').simulate('click');
-    expect(mockRejectAll.called).toBeFalsy();
+    expect(mockRejectAll).not.toHaveBeenCalled();
     expect(wrapper.find('#batchactions-RejectAll--confirmation')).toHaveLength(
       1,
     );
   });
 
   it('performs reject all action when Reject All button is confirmed', () => {
-    const mockRejectAll = sinon.spy();
+    const mockRejectAll = vi.fn();
 
     const wrapper = mount(
       <WrapRejectAll
@@ -125,9 +124,9 @@ describe('<RejectAll>', () => {
       />,
     );
 
-    expect(mockRejectAll.called).toBeFalsy();
+    expect(mockRejectAll).not.toHaveBeenCalled();
     wrapper.find('.reject-all').simulate('click');
     wrapper.find('.reject-all').simulate('click');
-    expect(mockRejectAll.called).toBeTruthy();
+    expect(mockRejectAll).toHaveBeenCalled();
   });
 });