kokkos: allow other LLVM-based compilers for ROCm (spack#3792)

* kokkos: allow other LLVM-based compilers for ROCm

Instead of always forcing hipcc, allow kokkos to be compiled directly with
either llvm or llvm-amdgpu (rocmcc).

* [@spackbot] updating style on behalf of rbberger

* Update package.py

Co-authored-by: Thomas Padioleau <thomas.padioleau@cea.fr>

* Update package.py

Co-authored-by: Thomas Padioleau <thomas.padioleau@cea.fr>

* [@spackbot] updating style on behalf of rbberger

---------

Co-authored-by: rbberger <rbberger@users.noreply.github.com>
Co-authored-by: Thomas Padioleau <thomas.padioleau@cea.fr>

Author: rbberger

repos/spack_repo/builtin/packages/kokkos/package.py

@@ -464,7 +464,7 @@ def cmake_args(self):
             options.append(self.define("CMAKE_CXX_COMPILER", self.kokkos_cxx))
         elif "+rocm" in self.spec:
             if "+cmake_lang" in self.spec:
-                if self.spec.satisfies("%cxx=clang"):
+                if self.spec.satisfies("%cxx=clang") or self.spec.satisfies("%cxx=rocmcc"):
                     options.append(self.define("CMAKE_HIP_COMPILER", self.compiler.cxx))
                 else:
                     options.append(
@@ -480,7 +480,7 @@ def cmake_args(self):
                     )
                 )
                 options.append(self.define("CMAKE_HIP_EXTENSIONS", False))
-            else:
+            elif not (self.spec.satisfies("%cxx=clang") or self.spec.satisfies("%cxx=rocmcc")):
                 options.append(self.define("CMAKE_CXX_COMPILER", self.spec["hip"].hipcc))
             options.append(self.define("Kokkos_ENABLE_ROCTHRUST", True))
 

repos/spack_repo/builtin/packages/kokkos_fft/package.py

@@ -75,7 +75,9 @@ def cmake_args(self):
             self.define("KokkosFFT_ENABLE_ONEMKL", self.spec.satisfies("device_backend=onemkl")),
         ]
 
-        if self.spec.satisfies("^kokkos+rocm"):
+        if self.spec.satisfies("^kokkos+rocm") and not (
+            self.spec.satisfies("^kokkos %cxx=clang") or self.spec.satisfies("^kokkos %cxx=rocmcc")
+        ):
             args.append(self.define("CMAKE_CXX_COMPILER", self.spec["hip"].hipcc))
         else:
             args.append(self.define("CMAKE_CXX_COMPILER", self["kokkos"].kokkos_cxx))

repos/spack_repo/builtin/packages/kokkos_kernels/package.py

@@ -223,7 +223,9 @@ def cmake_args(self):
         ]
 
         options.append(self.define("Kokkos_ROOT", spec["kokkos"].prefix))
-        if spec.satisfies("^kokkos+rocm"):
+        if spec.satisfies("^kokkos+rocm") and not (
+            spec.satisfies("^kokkos %cxx=clang") or spec.satisfies("^kokkos %cxx=rocmcc")
+        ):
             options.append(self.define("CMAKE_CXX_COMPILER", spec["hip"].hipcc))
         else:
             options.append(self.define("CMAKE_CXX_COMPILER", self["kokkos"].kokkos_cxx))