iss1757 - Fix Behat test in Moodle 5+

Author: EJMFarrow

tests/behat/behat_qtype_stack.php

@@ -28,7 +28,6 @@
 require_once(__DIR__ . '/../../../../../lib/behat/behat_base.php');
 
 use Moodle\BehatExtension\Exception\SkippedException;
-use PHPUnit\Framework\Assert;
 
 /**
  * Steps definitions related with the question bank management.
@@ -141,7 +140,9 @@ public function i_check_input_value($name, $value) {
             })();
         EOF;
         $formvalue = $this->evaluate_script($js);
-        Assert::assertEquals($value, $formvalue);
+        if ($formvalue !== $value) {
+            throw new \Exception("Expected input value '$value' but got '$formvalue'.");
+        }
     }
 
     /**
@@ -164,7 +165,9 @@ public function i_check_element_value($id, $value) {
         $formvalue = $this->evaluate_script($js);
         $this->getSession()->switchToWindow();
         $formvalue = str_replace(["\r\n", "\r", "\n"], '\n', $formvalue);
-        Assert::assertEquals($value, $formvalue);
+        if ($formvalue !== $value) {
+            throw new \Exception("Expected element value '$value' but got '$formvalue'.");
+        }
     }
 
     /**
@@ -187,7 +190,35 @@ public function i_check_element_value_contains($id, $value) {
         $formvalue = $this->evaluate_script($js);
         $this->getSession()->switchToWindow();
         $formvalue = str_replace(["\r\n", "\r", "\n"], '\n', $formvalue);
-        Assert::assertStringContainsString($value, $formvalue);
+        if (strpos($formvalue, $value) === false) {
+            throw new \Exception("Expected element value to contain '$value' but got '$formvalue'.");
+        }
+    }
+
+    /**
+     * Check an iframe element value contains one of two substrings.
+     *
+     * @param string $id id of element
+     * @param string $value1 first expected substring
+     * @param string $value2 second expected substring
+     *
+     * @Given /^I check the value of iframe element "(?P<id>[^"]*)" contains either '(?P<value1>[^']*)' or '(?P<value2>[^']*)'$/
+     */
+    public function i_check_element_value_contains_either($id, $value1, $value2) {
+        $generalcontext = behat_context_helper::get('behat_general');
+        $generalcontext->switch_to_iframe('stack-iframe-1');
+        $js = <<<EOF
+            return (function() {
+                let el = document.getElementById("$id");
+                return el ? el.textContent : null;
+            })();
+        EOF;
+        $formvalue = $this->evaluate_script($js);
+        $this->getSession()->switchToWindow();
+        $formvalue = str_replace(["\r\n", "\r", "\n"], '\n', $formvalue);
+        if (strpos($formvalue, $value1) === false && strpos($formvalue, $value2) === false) {
+            throw new \Exception("Expected element value to contain either '$value1' or '$value2' but got '$formvalue'.");
+        }
     }
 
     /**
@@ -275,7 +306,9 @@ public function i_check_images_are_loadable($number, $imgclass) {
         foreach ($urls as $url) {
             $this->execute('behat_general::i_visit', [$url]);
         }
-        Assert::assertEquals(true, count($urls) === (int) $number);
+        if (count($urls) !== (int) $number) {
+            throw new \Exception("Expected $number images but found " . count($urls) . ".");
+        }
     }
 
     /**

tests/behat/freetext.feature

@@ -40,4 +40,5 @@ Feature: Test input of correct answers on freetext inputs.
     And I check the input "ans3" is 'f(x) = 4sqrt(2x^2+1)+1'
     And I check the input "ans4" is 'f(0) = 5 => c = 1'
     And I check the input "ans5" is '{"matches":["f(x) = 4sqrt(2x^2+1)+c","f(x) = 4sqrt(2x^2+1)+1"]}'
-    And I check the value of iframe element "asciiContainerRow" contains '\begin{align*}\n& & \displaystyle{f{{\left({x}\right)}}}&={4}\sqrt{{{2}{x}^{{2}}+{1}}}+{c}\\\n& & \displaystyle{f{{\left({0}\right)}}}&={5}\Rightarrow{c}={1}\\\n& & \displaystyle{f{{\left({x}\right)}}}&={4}\sqrt{{{2}{x}^{{2}}+{1}}}+{1}\\\n\end{align*}\n'
+    # MathJax 3 will have rendered, MathJax 2 probably won't.
+    And I check the value of iframe element "asciiContainerRow" contains either '\begin{align*}\n& & \displaystyle{f{{\left({x}\right)}}}&={4}\sqrt{{{2}{x}^{{2}}+{1}}}+{c}\\\n& & \displaystyle{f{{\left({0}\right)}}}&={5}\Rightarrow{c}={1}\\\n& & \displaystyle{f{{\left({x}\right)}}}&={4}\sqrt{{{2}{x}^{{2}}+{1}}}+{1}\\\n\end{align*}\n' or '𝑓⁡(𝑥)=4⁢√2⁢𝑥2+1+1'