Skip to content

Commit 54b161b

Browse files
committed
iss1757 - Only flag answer changed when it's actually changed!
1 parent 557723a commit 54b161b

4 files changed

Lines changed: 8 additions & 5 deletions

File tree

corsscripts/ascii/stackascii.bundle.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

corsscripts/ascii/stackascii.bundle.js.map

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

corsscripts/ascii/stackascii.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,12 +61,15 @@ export default function init(inputIds, operations) {
6161
answerIndex++;
6262
if (extractor && answerEl) {
6363
let value = extractor(raw, blockCollector.blocks, currentop);
64+
const oldValue = answerEl.value;
6465
if (value === 'ERROR') {
6566
answerEl.value = '';
6667
} else {
6768
answerEl.value = value;
6869
}
69-
answerEl.dispatchEvent(new Event('change'));
70+
if (answerEl.value !== oldValue) {
71+
answerEl.dispatchEvent(new Event('change'));
72+
}
7073
}
7174
}
7275
});

tests/jest/ascii.stackascii.test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -198,7 +198,7 @@ describe('stackascii init', () => {
198198

199199
expect(mockFinalfunction).toHaveBeenCalledWith('beta', [], operations[0]);
200200
expect(env.answers[0].value).toBe('');
201-
expect(env.answers[0].dispatchEvent).toHaveBeenCalledTimes(1);
201+
expect(env.answers[0].dispatchEvent).not.toHaveBeenCalled();
202202
expect(env.output.innerHTML).toBe('beta');
203203
});
204204

0 commit comments

Comments
 (0)