broken-save - Show not saved warning for most Moodle errors. Fix display of Moodle errors.

Author: EJMFarrow

edit_stack_form.php

@@ -973,11 +973,21 @@ public function validation($fromform, $files) {
         if (empty($fromform['isbroken'])) {
             return $allerrors;
         } else {
-            if (array_search(stack_string('youmustconfirm'), $allerrors)) {
+            $mustconfirm = (array_search(stack_string('youmustconfirm'), $allerrors) === false) ? false : true;
+            if ($errors || $mustconfirm) {
+                $errortext = stack_string('notsaved');
+                if ($errors) {
+                    $errortext .= ' ' . stack_string('moodleerrors');
+                }
+                if ($mustconfirm) {
+                    $errortext .= ' ' . stack_string('mustconfirm');
+                }
+
                 $allerrors['versioninfo'] = isset($allerrors['versioninfo']) ?
-                    stack_string('notsaved') . ' ' . $allerrors['versioninfo'] : stack_string('notsaved');
+                    $errortext . ' ' . $allerrors['versioninfo'] : $errortext;
                 return $allerrors;
             } else {
+                // This is going to be [].
                 return $errors;
             }
         }

lang/en/qtype_stack.php

@@ -142,8 +142,8 @@
 $string['fixdollars_help'] = 'This option is useful if are copying and pasting (or typing) TeX with <code>$...$</code> and <code>$$...$$</code> delimiters. Those delimiters will be replaced by the recommended delimiters during the save process.';
 $string['forbiddendoubledollars'] = 'Please use the delimiters <code>\(...\)</code> for inline maths and <code>\[...\]</code> for display maths. <code>$...$</code> and <code>$$...$$</code> are not permitted. There is an option at the end of the form to fix this automatically.';
 $string['isbroken'] = 'Save as broken';
-$string['isbrokenlabel'] = 'Mark the question as broken. This will allow the question to be saved even with errors but it will not be displayed to students.';
-$string['isbroken_help'] = 'This option allows you to save your work even if a question is incomplete or has errors. You or a colleague can then return to work on it later. You will still need to tick the boxes to confirm any deletion of inputs or PRTs before the question will save.';
+$string['isbrokenlabel'] = 'Mark the question as broken. This will allow the question to be saved even with most errors but it will not be displayed to students.';
+$string['isbroken_help'] = 'This option allows you to save your work even if a question is incomplete or has errors. You or a colleague can then return to work on it later. You will still need to supply required fields and tick the boxes to confirm any deletion of inputs or PRTs before the question will save.';
 $string['forbidfloat'] = 'Forbid float';
 $string['forbidfloat_help'] = 'If set to yes, then any answer of the student which has a floating point number will be rejected as invalid.';
 $string['forbidfloat_link'] = '%%WWWROOT%%/question/type/stack/doc/doc.php/Authoring/Inputs.md#Forbid_Floats';
@@ -404,7 +404,9 @@
 $string['variantsselectionseed_help'] = 'Normally you can leave this box blank. If, however, you want two different questions in a quiz to use the same random seed, then type the same string in this box for the two questions (and deploy the same set of random seeds, if you are using deployed variants) and the random seeds for the two questions will be synchronised.';
 $string['verifyquestionandupdate'] = 'Verify the question text and update the form';
 $string['youmustconfirm'] = 'You must confirm here.';
-$string['notsaved'] = '** QUESTION WAS NOT SAVED ** You have changes to confirm.';
+$string['notsaved'] = '** QUESTION WAS NOT SAVED **';
+$string['mustconfirm'] = 'You have changes to confirm.';
+$string['moodleerrors'] = 'You have errors related to Moodle\'s basic question setup.';
 
 // Strings used by input elements.
 $string['studentinputtoolong'] = 'Your input is longer than permitted by STACK.';

questiontype.php

@@ -1898,7 +1898,9 @@ public function validate_fromform($fromform, $errors, $question) {
                         $messages[$key] = implode(' ', $val);
                     }
                 }
-                $errors[$field] = implode(' ', $messages);
+                // Fixed to handle strings. We got away with e.g. default mark errors
+                // just not showing before but this previously threw an exception in PHP 8.x.
+                $errors[$field] = (is_array($messages)) ? implode(' ', $messages) : $messages;
                 $errorsexit = true;
             } else {
                 unset($errors[$field]);