Allow most input types to become manually graded.

sangwinc · sangwinc · commit 93e3d8fb6d22 · 2026-05-14T16:08:17.000+01:00
diff --git a/doc/en/Authoring/Inputs/Input_options.md b/doc/en/Authoring/Inputs/Input_options.md
@@ -6,34 +6,36 @@ This is reference documentation for the input options.
 
 This table lists all options, and which inputs use/respect them.  The `.` means the option is ignored.
 
-Options           | Alg | Num | Units | Matrix | Check | Radio | Drop | T/F | TextArea | Equiv | String | Notes
-------------------|-----|-----|-------|--------|-------|-------|------|-----|----------|-------|--------|------
-Box size          |  Y  |  Y  |  Y    |   Y    |   .   |   .   |   .  |  .  |    Y     |   Y   |   Y    |   Y
-Strict Syn        |  Y  | (1) |  (1)  |   Y    |   .   |   .   |   .  |  .  |    Y     |   Y   |   .    |   .
-Insert stars      |  Y  |  Y  |  Y    |   Y    |   .   |   .   |   .  |  .  |    Y     |   Y   |   .    |   .
-Syntax hint       |  Y  |  Y  |  Y    |   Y    |   .   |   .   |   .  |  .  |    Y     |   Y   |   Y    |   Y
-Hint att          |  Y  |  Y  |  Y    |   Y    |   .   |   .   |   .  |  .  |    Y     |   Y   |   Y    |   Y
-Forbidden words   |  Y  |  Y  |  Y    |   Y    |   .   |   .   |   .  |  .  |    Y     |   Y   |   .    |   .
-Allowed words     |  Y  |  Y  |  Y    |   Y    |   .   |   .   |   .  |  .  |    Y     |   Y   |   .    |   .
-Forbid float      |  Y  |  Y  |  Y    |   Y    |   .   |   .   |   .  |  .  |    Y     |   Y   |   .    |   .
-Lowest terms      |  Y  |  Y  |  Y    |   Y    |   .   |   .   |   .  |  .  |    Y     |   Y   |   .    |   .
-Check type        |  Y  |  Y  |  Y    |   Y    |   .   |   .   |   .  |  .  |    .     |   .   |   .    |   .
-Must verify       |  Y  |  Y  |  Y    |   Y    |   Y   |   Y   |   Y  |  Y  |    Y     |   Y   |   Y    |   .
-Show validation   |  Y  |  Y  |  Y    |   Y    |   Y   |   Y   |   Y  |  Y  |    Y     |   Y   |   Y    |   .
-**Extra options:**|     |     |       |        |       |       |      |     |          |       |        |
-`rationalize`   |  Y  |  Y  |  .    |   .    |   .   |   .   |   .  |  .  |    .     |   .   |   .    |   .
-min/max sf/dp     |  .  |  Y  |  Y    |   .    |   .   |   .   |   .  |  .  |    .     |   .   |   .    |   .
-`floatnum`      |  .  |  Y  |  .    |   .    |   .   |   .   |   .  |  .  |    .     |   .   |   .    |   .
-`intnum`        |  .  |  Y  |  .    |   .    |   .   |   .   |   .  |  .  |    .     |   .   |   .    |   .
-`rationalnum`   |  .  |  Y  |  .    |   .    |   .   |   .   |   .  |  .  |    .     |   .   |   .    |   .
-`consolidatesubscripts` |  Y  |  .  |  Y    |   Y    |   .   |   .   |   .  |  .  |    .     |   .   |   .    |   .
-`negpow`        |  .  |  .  |  Y    |   .    |   .   |   .   |   .  |  .  |    .     |   .   |   .    |   .
-`simp`            |  Y  |  Y  |  Y    |   Y    |   .   |   .   |   .  |  .  |    Y     |   .   |   .    |   .
-`align`        |  Y  |  Y  |  Y    |   .    |   .   |   .   |   .  |  .  |    .     |   .   |   .    |   .
-`nounits`      |  Y  |  Y  |  Y    |   Y    |   Y   |   Y   |   Y  |  .  |    .     |   Y   |   .    |   .
-`checkvars`    |  Y  |  .  |  .    |   Y    |   .   |   .   |   .  |  .  |    .     |   Y   |   .    |   .
-`validator`    |  Y  |  Y  |  Y    |   Y    |   .   |   .   |   .  |  .  |    .     |   .   |   Y    |   .
-`feedback`    |  Y  |  .  |  Y    |   Y    |   .   |   .   |   .  |  .  |    .     |   .   |   .    |   .
+Options           | Alg | Num | Units | Matrix | VarMat | Check | Radio | Drop | T/F | TextArea | Equiv | String | Notes | Freetext
+------------------|-----|-----|-------|--------|--------|-------|-------|------|-----|----------|-------|--------|-------|---------
+Box size          |  Y  |  Y  |  Y    |   Y    |   Y    |   .   |   .   |  .   |  .  |    Y     |   Y   |   Y    |   Y   |   Y
+Strict Syn        |  Y  | (1) |  (1)  |   Y    |   Y    |   .   |   .   |  .   |  .  |    Y     |   Y   |   .    |   .   |   .
+Insert stars      |  Y  |  Y  |  Y    |   Y    |   Y    |   .   |   .   |  .   |  .  |    Y     |   Y   |   .    |   .   |   .
+Syntax hint       |  Y  |  Y  |  Y    |   Y    |   Y    |   .   |   .   |  .   |  .  |    Y     |   Y   |   Y    |   Y   |   Y
+Hint att          |  Y  |  Y  |  Y    |   Y    |   Y    |   .   |   .   |   .  |  .  |    Y     |   Y   |   Y    |   Y   |   Y
+Forbidden words   |  Y  |  Y  |  Y    |   Y    |   Y    |   .   |   .   |   .  |  .  |    Y     |   Y   |   .    |   .   |   .
+Allowed words     |  Y  |  Y  |  Y    |   Y    |   Y    |   .   |   .   |   .  |  .  |    Y     |   Y   |   .    |   .   |   .
+Forbid float      |  Y  |  Y  |  Y    |   Y    |   Y    |   .   |   .   |   .  |  .  |    Y     |   Y   |   .    |   .   |   .
+Lowest terms      |  Y  |  Y  |  Y    |   Y    |   Y    |   .   |   .   |   .  |  .  |    Y     |   Y   |   .    |   .   |   .
+Check type        |  Y  |  Y  |  Y    |   Y    |   Y    |   .   |   .   |   .  |  .  |    .     |   .   |   .    |   .   |   .
+Must verify       |  Y  |  Y  |  Y    |   Y    |   Y    |   Y   |   Y   |   Y  |  Y  |    Y     |   Y   |   Y    |   Y   |   Y
+Show validation   |  Y  |  Y  |  Y    |   Y    |   Y    |   Y   |   Y   |   Y  |  Y  |    Y     |   Y   |   Y    |   Y   |   Y
+**Extra options:**|     |     |       |        |        |       |       |      |     |          |       |        |       |
+`rationalize`   |  Y  |  Y  |  .    |   .    |   .    |   .   |   .   |   .  |  .  |    .     |   .   |   .    |   .   |   .
+min/max sf/dp     |  .  |  Y  |  Y    |   .    |   .    |   .   |   .   |   .  |  .  |    .     |   .   |   .    |   .   |   .
+`floatnum`      |  .  |  Y  |  .    |   .    |   .    |   .   |   .   |   .  |  .  |    .     |   .   |   .    |   .   |   .
+`intnum`        |  .  |  Y  |  .    |   .    |   .    |   .   |   .   |   .  |  .  |    .     |   .   |   .    |   .   |   .
+`rationalnum`   |  .  |  Y  |  .    |   .    |   .    |   .   |   .   |   .  |  .  |    .     |   .   |   .    |   .   |   .
+`consolidatesubscripts` |  Y  |  .  |  Y    |   Y    |   Y    |   .   |   .   |   .  |  .  |    .     |   .   |   .    |   .   |   .
+`negpow`        |  .  |  .  |  Y    |   .    |   .    |   .   |   .   |   .  |  .  |    .     |   .   |   .    |   .   |   .
+`simp`            |  Y  |  Y  |  Y    |   Y    |   Y    |   .   |   .   |   .  |  .  |    Y     |   .   |   .    |   .   |   .
+`align`        |  Y  |  Y  |  Y    |   .    |   .    |   .   |   .   |   .  |  .  |    .     |   .   |   .    |   .   |   .
+`nounits`      |  Y  |  Y  |  Y    |   Y    |   Y    |   Y   |   Y   |   Y  |  .  |    .     |   Y   |   .    |   .   |   .
+`checkvars`    |  Y  |  .  |  .    |   Y    |   Y    |   .   |   .   |   .  |  .  |    .     |   Y   |   .    |   .   |   .
+`validator`    |  Y  |  Y  |  Y    |   Y    |   Y    |   .   |   .   |   .  |  .  |    .     |   .   |   Y    |   .   |   Y
+`feedback`     |  Y  |  .  |  Y    |   Y    |   Y    |   .   |   .   |   .  |  .  |    .     |   .   |   .    |   .   |   .
+`monospace`    |  Y  |  Y  |  Y    |   .    |   Y    |   .   |   .   |   .  |  .  |    .     |   .   |   .    |   .   |   .
+`manualgraded` |  Y  |  Y  |  Y    |   Y    |   Y    |   .   |   .   |   .  |  .  |    Y     |   Y   |   Y    |   Y   |   Y
 
 For documentation about the various options not documented on this page look at the pages for the specific inputs in which each option is used.
 
@@ -151,6 +153,11 @@ This option is available for algebraic, numerical, units and varmatrix inputs. I
 
 If `monospace` is not specified, then the CURRENT system default for the given input type will be used when the question is displayed. 
 
+### Extra option: manualgraded ###
+
+Most input types support the extra option extra option `manualgraded`, and the default is `manualgraded:false`.  Only freetext inputs have default `manualgraded:true`.  When `manualgraded:true` then the _whole STACK question_ will require manual grading!  See [Semi-automatic Marking](../../Moodle/Semi-automatic_Marking.md) for more details.
+
+
 ## Future extra options ##
 
 In the future we are likely to add additional functionality via the _extra options_ fields.  This is because the form-based support becomes ever more complex, intimidating and difficult to navigate.
diff --git a/doc/en/Authoring/Inputs/Text_input.md b/doc/en/Authoring/Inputs/Text_input.md
@@ -21,7 +21,7 @@ This input is a text area into which students may type whatever they choose.  Th
 Notes
 
 1.  All the notes for "string" inputs above still apply.
-2.  The freetext input has a special extra option `manualgraded`, and the default option value is `manualgraded:true`.  If you specify `manualgraded:false` then the _whole STACK question_ will require manual grading!
+2.  The freetext input takes the default option value is `manualgraded:true`.  If you specify `manualgraded:true` then the _whole STACK question_ will require manual grading!
 3.  Part of this input can be linked to an automatically graded STACK input, e.g. an algebraic input (final answer), textarea (last lines) or units input.
 
 #### JSON input ####
@@ -30,19 +30,22 @@ The JSXGraph, GeoGebra and Parsons blocks return a JSON object.  When linking to
 
 This input gives the _teacher_ a JSON pretty print view of the JSON object for debugging.
 
+### Parsons input ###
+
+A special [Parsons input](../../Specialist_tools/Drag_and_drop/index.md), is available to store the JSON object generated by the Parsons block.
+
+### GeoGebra input ###
+
+A special [GeoGebra input](../../Specialist_tools/GeoGebra/index.md), is available to store the JSON object generated by the GeoGebra block.
+
 #### Notes input ####
 
 This input is a text area into which students may type whatever they choose.  It can be used to gather their notes or "working".  However, this input is always considered as "invalid", so that any potential response tree which relies on this input will never get evaluated!
 
 This input type can be used for
 
 1. surveys;
-2. answers which are not automatically marked, contributing to [semi-automatic marking](../../Moodle/Semi-automatic_Marking.md).
-
-The notes input has a special extra option `manualgraded`, and the default option value is `manualgraded:false`.  If you specify `manualgraded:true` then the _whole STACK question_ will require manual grading!
+2. answers which are not automatically marked, contributing to [semi-automatic marking](../../Moodle/Semi-automatic_Marking.md).  Set the extra option `manualgraded:true`, but note that the _whole STACK question_ will require manual grading!
 
 Note, for consistency with other inputs the teacher must still supply an answer, e.g. the empty string `""`.  This answer is not used.
 
-### Parsons input ###
-
-A special [Parsons input](../../Specialist_tools/Drag_and_drop/index.md), is available to store the JSON object generated by the Parsons block.
diff --git a/doc/en/Developer/Development_track.md b/doc/en/Developer/Development_track.md
@@ -13,8 +13,7 @@ Issues with [github milestone 4.13.0](https://github.com/maths/moodle-qtype_stac
 2. Support for Maxima 5.47.0, 5.48.0, and 5.49.0.  This includes a fix for issue #1281 from 5.48.0.
 3. Question tests can now test the whole route through a PRT, rather than just the final node.  This is a significant improvement on the ability to test questions.  This is back-compatible with older questions.
 4. Add in a new "free-text" input to allow student to input typed free-text proof.
-
---------------------------------------
+5. Allow most input types to use the extra option 'manualgraded'.
 
 ## Better testing
 
diff --git a/doc/en/Moodle/Semi-automatic_Marking.md b/doc/en/Moodle/Semi-automatic_Marking.md
@@ -13,11 +13,13 @@ STACK provides the "free-text" and "notes" [input type](../Authoring/Inputs/Text
 
 ## Manual grading.
 
-The free-text and notes inputs have a special extra option `manualgraded`.  When `manualgraded:true` then the _whole STACK question_ will require manual grading!
+Most input types support the extra option extra option `manualgraded`, and the default is `manualgraded:false`.  When `manualgraded:true` then the _whole STACK question_ will require manual grading!
+
+The free-text default extra option `manualgraded:true`.
 
 There really is no way to mix automatic and manually grading within a question. Therefore, if you want automatic and manual marking you have two options.
 
-1. Use separate questions.  If you need to serparate out parts to automatic and manually graded parts then you can consider [variant matching](../Deploying_matched_varients) to ensure random parts have the same seed.
+1. Use separate questions.  If you need to serparate out parts to automatic and manually graded parts then you can consider [variant matching](../STACK_question_admin/Deploying_matched_variants.md) to ensure random parts have the same seed.
 2. Manual grade, taking into account some automatic marks when you manually grade.
 
 Once a student has completed the quiz, navigate to 
diff --git a/question.php b/question.php
@@ -311,6 +311,11 @@ public function make_behaviour(question_attempt $qa, $preferredbehaviour) {
             return question_engine::make_behaviour('informationitem', $qa, $preferredbehaviour);
         }
 
+        // This is an edge case to stop survey items automatically becoming manually graded.
+        if (empty($this->prts)) {
+            return question_engine::make_behaviour('manualgraded', $qa, $preferredbehaviour);
+        }
+
         if ($this->is_manually__graded()) {
             return question_engine::make_behaviour('manualgraded', $qa, $preferredbehaviour);
         }
@@ -335,9 +340,6 @@ public function make_behaviour(question_attempt $qa, $preferredbehaviour) {
      * @return bool
      */
     public function is_manually__graded() {
-        if (empty($this->prts)) {
-            return true;
-        }
         if (!empty($this->inputs)) {
             foreach ($this->inputs as $input) {
                 if ($input->get_extra_option('manualgraded')) {
diff --git a/stack/input/algebraic/algebraic.class.php b/stack/input/algebraic/algebraic.class.php
@@ -36,6 +36,7 @@ class stack_algebraic_input extends stack_input {
         'feedback' => false,
         'monospace' => false,
         'basen' => false,
+        'manualgraded' => false,
     ];
 
     // phpcs:ignore moodle.Commenting.MissingDocblock.Function
diff --git a/stack/input/equiv/equiv.class.php b/stack/input/equiv/equiv.class.php
@@ -54,6 +54,7 @@ class stack_equiv_input extends stack_input {
         'calculus' => false,
         'consolidatesubscripts' => false,
         'checkvars' => 0,
+        'manualgraded' => false,
     ];
 
     // phpcs:ignore moodle.Commenting.MissingDocblock.Function
diff --git a/stack/input/geogebra/geogebra.class.php b/stack/input/geogebra/geogebra.class.php
@@ -34,6 +34,7 @@ class stack_geogebra_input extends stack_input {
         'align' => 'left',
         'consolidatesubscripts' => false,
         'checkvars' => 0,
+        'manualgraded' => false,
     ];
 
     // phpcs:ignore moodle.Commenting.MissingDocblock.Function
diff --git a/stack/input/json/json.class.php b/stack/input/json/json.class.php
@@ -33,6 +33,7 @@ class stack_json_input extends stack_string_input {
         'hideanswer' => false,
         'allowempty' => false,
         'validator' => false,
+        'manualgraded' => false,
     ];
 
     /**
diff --git a/stack/input/matrix/matrix.class.php b/stack/input/matrix/matrix.class.php
@@ -37,6 +37,7 @@ class stack_matrix_input extends stack_input {
         'checkvars' => 0,
         'validator' => false,
         'feedback' => false,
+        'manualgraded' => false,
     ];
 
     // phpcs:ignore moodle.Commenting.MissingDocblock.Function
diff --git a/stack/input/numerical/numerical.class.php b/stack/input/numerical/numerical.class.php
@@ -50,6 +50,7 @@ class stack_numerical_input extends stack_input {
         'align' => 'left',
         'validator' => false,
         'monospace' => false,
+        'manualgraded' => false,
     ];
 
     // phpcs:ignore moodle.Commenting.MissingDocblock.Function
diff --git a/stack/input/string/string.class.php b/stack/input/string/string.class.php
@@ -32,6 +32,7 @@ class stack_string_input extends stack_algebraic_input {
         'hideanswer' => false,
         'allowempty' => false,
         'validator' => false,
+        'manualgraded' => false,
     ];
 
     /**
diff --git a/stack/input/textarea/textarea.class.php b/stack/input/textarea/textarea.class.php
@@ -35,6 +35,7 @@ class stack_textarea_input extends stack_input {
         'nounits' => true,
         'simp' => false,
         'consolidatesubscripts' => false,
+        'manualgraded' => false,
     ];
 
     // phpcs:ignore moodle.Commenting.MissingDocblock.Function
diff --git a/stack/input/units/units.class.php b/stack/input/units/units.class.php
@@ -43,6 +43,7 @@ class stack_units_input extends stack_input {
         'validator' => false,
         'feedback' => false,
         'monospace' => false,
+        'manualgraded' => false,
     ];
 
 
diff --git a/stack/input/varmatrix/varmatrix.class.php b/stack/input/varmatrix/varmatrix.class.php
@@ -33,6 +33,7 @@ class stack_varmatrix_input extends stack_input {
         'checkvars' => 0,
         'validator' => false,
         'monospace' => false,
+        'manualgraded' => false,
     ];
 
     // phpcs:ignore moodle.Commenting.MissingDocblock.Function
