iss1748 - Really rough ASCII input that uses final line as answer

Author: EJMFarrow

amd/build/stackjsvle.min.js

@@ -404,7 +404,11 @@ define([
                 response['input-readonly'] = input.hasAttribute('disabled');
             } else if (input.nodeName.toLowerCase() === 'textarea') {
                 response.value = input.value;
-                response['input-type'] = 'textarea';
+                if (input.dataset.stackInputType === 'ascii') {
+                    response['input-type'] = 'ascii';
+                } else {
+                    response['input-type'] = 'textarea';
+                }
                 response['input-readonly'] = input.hasAttribute('disabled');
             } else if (input.type === 'checkbox') {
                 response.value = input.checked;

amd/build/stackjsvle.min.js.map

@@ -5,6 +5,7 @@ export default function init(markdownId) {
 		clearTimeout(debounceTimer);
 		debounceTimer = setTimeout(renderMath(), 100); // debounce 100ms
 	});
+	renderMath();
 }
 
 var markdownContainerId = null;

amd/src/stackjsvle.js

@@ -760,7 +760,8 @@ protected function definition_input($inputname, MoodleQuickForm $mform, $counts)
             $inputname . 'checkanswertype',
             $inputname . 'type',
             'in',
-            ['radio', 'checkbox', 'dropdown', 'boolean', 'textarea', 'equiv', 'string', 'json', 'notes', 'parsons']
+            ['radio', 'checkbox', 'dropdown', 'boolean', 'textarea',
+                'ascii', 'equiv', 'string', 'json', 'notes', 'parsons',]
         );
 
         $mform->addElement(

corsscripts/ascii/stackascii.js

@@ -189,6 +189,7 @@
 $string['inputtype_help'] = 'This determines the type of the input element, e.g. form field, true/false, text area.';
 $string['inputtype_link'] = '%%WWWROOT%%/question/type/stack/doc/doc.php/Authoring/Inputs.md';
 $string['inputtypealgebraic'] = 'Algebraic input';
+$string['inputtypeascii'] = 'ASCII input';
 $string['inputtypeboolean'] = 'True/False';
 $string['inputtypedropdown'] = 'Drop down list';
 $string['inputtypecheckbox'] = 'Checkbox';

edit_stack_form.php

@@ -15,7 +15,7 @@
 // along with STACK.  If not, see <http://www.gnu.org/licenses/>.
 
 /**
- * Add description here!
+ * An ASCIIMaths display block - e.g. [[ascii input="ans1"]][[/ascii]]
  * @package    qtype_stack
  * @copyright  2024 University of Edinburgh.
  * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later.

lang/en/qtype_stack.php

@@ -29,15 +29,6 @@
  * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
 class stack_ascii_input extends stack_textarea_input {
-    // phpcs:ignore moodle.Commenting.VariableComment.Missing
-    protected $extraoptions = [
-        'hideanswer' => false,
-        'allowempty' => false,
-        'nounits' => true,
-        'simp' => false,
-        'consolidatesubscripts' => false,
-    ];
-
     // phpcs:ignore moodle.Commenting.MissingDocblock.Function
     public function render(stack_input_state $state, $fieldname, $readonly, $tavalue) {
         // Note that at the moment, $this->boxHeight and $this->boxWidth are only
@@ -80,7 +71,7 @@ public function render(stack_input_state $state, $fieldname, $readonly, $tavalue
         }
 
         // Metadata for JS users.
-        $attributes['data-stack-input-type'] = 'textarea';
+        $attributes['data-stack-input-type'] = 'ascii';
         if ($this->options->get_option('decimals') === ',') {
             $attributes['data-stack-input-decimal-separator']  = ',';
             $attributes['data-stack-input-list-separator'] = ';';
@@ -92,54 +83,6 @@ public function render(stack_input_state $state, $fieldname, $readonly, $tavalue
         return html_writer::tag('textarea', htmlspecialchars($current, ENT_COMPAT), $attributes);
     }
 
-    // phpcs:ignore moodle.Commenting.MissingDocblock.Function
-    public function render_api_data($tavalue) {
-        if ($this->errors) {
-            throw new stack_exception("Error rendering input: " . implode(',', $this->errors));
-        }
-
-        $data = [];
-
-        $data['type'] = 'textarea';
-        $data['boxWidth'] = $this->parameters['boxWidth'];
-        $data['syntaxHint'] = $this->maxima_to_raw_input($this->parameters['syntaxHint']);
-
-        return $data;
-    }
-
-    // phpcs:ignore moodle.Commenting.MissingDocblock.Function
-    public function add_to_moodleform_testinput(MoodleQuickForm $mform) {
-        $mform->addElement('text', $this->name, $this->name, ['size' => $this->parameters['boxWidth']]);
-        $mform->setDefault($this->name, $this->parameters['syntaxHint']);
-        $mform->setType($this->name, PARAM_RAW);
-    }
-
-    /**
-     * Transforms the student's response input into an array.
-     * Most return the same as went in.
-     *
-     * @param array|string $in
-     * @return string
-     */
-    protected function response_to_contents($response) {
-        $contents = [];
-        if (array_key_exists($this->name, $response)) {
-            $sans = $response[$this->name];
-            if (trim($sans) == '' && $this->get_extra_option('allowempty')) {
-                return ['EMPTYANSWER'];
-            }
-            $rowsin = explode("\n", $sans);
-            $rowsout = [];
-            foreach ($rowsin as $key => $row) {
-                $cleanrow = trim($row);
-                if ($cleanrow !== '') {
-                    $contents[] = $cleanrow;
-                }
-            }
-        }
-        return $contents;
-    }
-
     // phpcs:ignore moodle.Commenting.MissingDocblock.Function
     protected function caslines_to_answer($caslines, $secrules = false) {
         $vals = [];
@@ -154,6 +97,7 @@ protected function caslines_to_answer($caslines, $secrules = false) {
             'nounify' => 1,
             'nontuples' => false,
         ];
+        $caslines = [end($caslines)];
         foreach ($caslines as $line) {
             $str = $line->ast_to_string(null, $params);
             if ($line->get_valid() || $str === 'EMPTYANSWER') {
@@ -167,62 +111,6 @@ protected function caslines_to_answer($caslines, $secrules = false) {
         return stack_ast_container::make_from_student_source($s, '', $secrules);
     }
 
-    /**
-     * Transforms the contents array into a maxima expression.
-     *
-     * @param array|string $in
-     * @return string
-     */
-    public function contents_to_maxima($contents) {
-        return '[' . implode(',', $contents) . ']';
-    }
-
-    /**
-     * Transforms a Maxima list into raw input.
-     *
-     * @param string $in
-     * @return string
-     */
-    protected function maxima_to_raw_input($in) {
-        $delim = ',';
-        if ($this->options->get_option('decimals') === ',') {
-            $delim = ';';
-        }
-        $values = stack_utils::list_to_array($in, false, $delim);
-        foreach ($values as $key => $val) {
-            if (trim($val) != '') {
-                $cs = stack_ast_container::make_from_teacher_source($val);
-                if ($cs->get_valid()) {
-                    $val = $cs->get_inputform(false, 0);
-                }
-            }
-            $values[$key] = $val;
-        }
-        return implode("\n", $values);
-    }
-
-    // phpcs:ignore moodle.Commenting.MissingDocblock.Function
-    protected function ajax_to_response_array($in) {
-        $in = explode('<br>', $in);
-        $in = implode("\n", $in);
-        return [$this->name => $in];
-    }
-
-    /**
-     * Transforms a Maxima expression into an array of raw inputs which are part of a response.
-     * Most inputs are very simple, but textarea and matrix need more here.
-     *
-     * @param string $in
-     * @return string
-     */
-    public function maxima_to_response_array($in) {
-        $response[$this->name] = $this->maxima_to_raw_input($in);
-        if ($this->requires_validation()) {
-            $response[$this->name . '_val'] = $in;
-        }
-        return $response;
-    }
-
     /**
      * This function constructs the display variable for validation.
      *
@@ -242,7 +130,10 @@ protected function validation_display(
         $ilines,
         $notes
     ) {
-
+        $caslines = [end($caslines)];
+        $ilines = [end($ilines)];
+        $errors = [end($errors)];
+        $valid = $caslines[0]->get_valid();
         $rows = [];
         foreach ($caslines as $index => $cs) {
             $row = [];
@@ -312,7 +203,7 @@ public static function get_parameters_defaults() {
         return [
             'mustVerify'         => true,
             'showValidation'     => 1,
-            'boxWidth'           => 20,
+            'boxWidth'           => 30,
             'insertStars'        => 0,
             'syntaxHint'         => '',
             'syntaxAttribute'    => 0,
@@ -325,43 +216,4 @@ public static function get_parameters_defaults() {
         ];
     }
 
-    /**
-     * Each actual extension of this base class must decide what parameter values are valid.
-     * @return array of parameters names.
-     */
-    public function internal_validate_parameter($parameter, $value) {
-        $valid = true;
-        switch ($parameter) {
-            case 'boxWidth':
-                $valid = is_int($value) && $value > 0;
-                break;
-
-            case 'boxHeight':
-                $valid = is_int($value) && $value > 0;
-                break;
-        }
-        return $valid;
-    }
-
-    /**
-     * Add description here.
-     * @return string the teacher's answer, displayed to the student in the general feedback.
-     */
-    public function get_teacher_answer_display($value, $display) {
-        if ($this->get_extra_option('hideanswer')) {
-            return '';
-        }
-        $values = stack_utils::list_to_array($value, false);
-        foreach ($values as $key => $val) {
-            if (trim($val) !== '') {
-                $cs = stack_ast_container::make_from_teacher_source($val);
-                $cs->get_valid();
-                $val = '<code>' . $cs->get_inputform(true, 0, true, $this->options->get_option('decimals')) . '</code>';
-            }
-            $values[$key] = $val;
-        }
-        $value = "<br/>" . implode("<br/>", $values);
-
-        return stack_string('teacheranswershow', ['value' => $value, 'display' => $display]);
-    }
 }