iss1757 - Fix Behat for Moodle 5.0

Author: EJMFarrow

tests/behat/behat_qtype_stack.php

@@ -170,41 +170,18 @@ public function i_check_element_value($id, $value) {
         }
     }
 
-    /**
-     * Check an iframe element value contains a substring
-     *
-     * @param string $id id of element
-     * @param string $value the expected substring
-     *
-     * @Given /^I check the value of iframe element "(?P<id>[^"]*)" contains '(?P<value>[^']*)'$/
-     */
-    public function i_check_element_value_contains($id, $value) {
-        $generalcontext = behat_context_helper::get('behat_general');
-        $generalcontext->switch_to_iframe('stack-iframe-1');
-        $js = <<<EOF
-            return (function() {
-                let el = document.getElementById("$id");
-                return el ? el.textContent : null;
-            })();
-        EOF;
-        $formvalue = $this->evaluate_script($js);
-        $this->getSession()->switchToWindow();
-        $formvalue = str_replace(["\r\n", "\r", "\n"], '\n', $formvalue);
-        if (strpos($formvalue, $value) === false) {
-            throw new \Exception("Expected element value to contain '$value' but got '$formvalue'.");
-        }
-    }
 
     /**
-     * Check an iframe element value contains one of two substrings.
+     * Check an iframe element value contains one of three substrings.
      *
      * @param string $id id of element
      * @param string $value1 first expected substring
      * @param string $value2 second expected substring
+     * @param string $value3 third expected substring
      *
-     * @Given /^I check the value of iframe element "(?P<id>[^"]*)" contains either '(?P<value1>[^']*)' or '(?P<value2>[^']*)'$/
+     * @Given /^I check the value of iframe element "(?P<id>[^"]*)" contains one of '(?P<value1>[^']*)' or '(?P<value2>[^']*)' or '(?P<value3>[^']*)'$/
      */
-    public function i_check_element_value_contains_either($id, $value1, $value2) {
+    public function i_check_element_value_contains_one_of($id, $value1, $value2, $value3) {
         $generalcontext = behat_context_helper::get('behat_general');
         $generalcontext->switch_to_iframe('stack-iframe-1');
         $js = <<<EOF
@@ -216,8 +193,8 @@ public function i_check_element_value_contains_either($id, $value1, $value2) {
         $formvalue = $this->evaluate_script($js);
         $this->getSession()->switchToWindow();
         $formvalue = str_replace(["\r\n", "\r", "\n"], '\n', $formvalue);
-        if (strpos($formvalue, $value1) === false && strpos($formvalue, $value2) === false) {
-            throw new \Exception("Expected element value to contain either '$value1' or '$value2' but got '$formvalue'.");
+        if (strpos($formvalue, $value1) === false && strpos($formvalue, $value2) === false && strpos($formvalue, $value3) === false) {
+            throw new \Exception("Expected element value to contain one of '$value1', '$value2' or '$value3' but got '$formvalue'.");
         }
     }
 

tests/behat/freetext.feature

@@ -40,5 +40,5 @@ Feature: Test input of correct answers on freetext inputs.
     And I check the input "ans3" is 'f(x) = 4sqrt(2x^2+1)+1'
     And I check the input "ans4" is 'f(0) = 5 => c = 1'
     And I check the input "ans5" is '{"matches":["f(x) = 4sqrt(2x^2+1)+c","f(x) = 4sqrt(2x^2+1)+1"]}'
-    # MathJax 3 will have rendered, MathJax 2 probably won't.
-    And I check the value of iframe element "asciiContainerRow" contains either '\begin{align*}\n& & \displaystyle{f{{\left({x}\right)}}}&={4}\sqrt{{{2}{x}^{{2}}+{1}}}+{c}\\\n& & \displaystyle{f{{\left({0}\right)}}}&={5}\Rightarrow{c}={1}\\\n& & \displaystyle{f{{\left({x}\right)}}}&={4}\sqrt{{{2}{x}^{{2}}+{1}}}+{1}\\\n\end{align*}\n' or '𝑓⁡(𝑥)=4⁢√2⁢𝑥2+1+1'
+    # MathJax 3 will have rendered, MathJax 2 probably won't. Moodle 5 gives us the flattened plain text. Sigh...
+    And I check the value of iframe element "asciiContainerRow" contains one of '\begin{align*}\n& & \displaystyle{f{{\left({x}\right)}}}&={4}\sqrt{{{2}{x}^{{2}}+{1}}}+{c}\\\n& & \displaystyle{f{{\left({0}\right)}}}&={5}\Rightarrow{c}={1}\\\n& & \displaystyle{f{{\left({x}\right)}}}&={4}\sqrt{{{2}{x}^{{2}}+{1}}}+{1}\\\n\end{align*}\n' or '𝑓⁡(𝑥)=4⁢√2⁢𝑥2+1+1' or 'f(x)=42x2+1+1'