Skip to content

Commit 3e51532

Browse files
authored
Merge pull request #1373 from mathuo/fix/focus-visible-indicators
fix(dockview-core): use :focus-visible for keyboard focus indicators
2 parents ea0bdfd + ed426ab commit 3e51532

2 files changed

Lines changed: 9 additions & 6 deletions

File tree

packages/dockview-core/src/dockview/components/tab/defaultTab.scss

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,11 @@
2727
.dv-tab {
2828
flex-shrink: 0;
2929

30-
&:focus-within,
31-
&:focus {
30+
// Keyboard-only focus ring: :focus-visible suppresses it on mouse click,
31+
// :has(:focus-visible) keeps it when a child (e.g. the close button) is
32+
// keyboard-focused — the descendant case the old :focus-within covered.
33+
&:focus-visible,
34+
&:has(:focus-visible) {
3235
position: relative;
3336

3437
&::after {

packages/dockview-core/src/paneview/paneview.scss

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -68,8 +68,8 @@
6868
cursor: pointer;
6969
}
7070

71-
&:focus,
72-
&:focus-within {
71+
&:focus-visible,
72+
&:has(:focus-visible) {
7373
&:before {
7474
position: absolute;
7575
top: 0;
@@ -94,8 +94,8 @@
9494
position: relative;
9595
outline: none;
9696

97-
&:focus,
98-
&:focus-within {
97+
&:focus-visible,
98+
&:has(:focus-visible) {
9999
&:before {
100100
position: absolute;
101101
top: 0;

0 commit comments

Comments
 (0)