Skip to content

fix(dockview-core): use :focus-visible for keyboard focus indicators #1373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mathuo merged 1 commit into from
Jun 23, 2026
+9 −6
Merged

fix(dockview-core): use :focus-visible for keyboard focus indicators #1373

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions packages/dockview-core/src/dockview/components/tab/defaultTab.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,11 @@
.dv-tab {
flex-shrink: 0;

&:focus-within,
&:focus {
// Keyboard-only focus ring: :focus-visible suppresses it on mouse click,
// :has(:focus-visible) keeps it when a child (e.g. the close button) is
// keyboard-focused — the descendant case the old :focus-within covered.
&:focus-visible,
&:has(:focus-visible) {
position: relative;

&::after {
Expand Down
8 changes: 4 additions & 4 deletions packages/dockview-core/src/paneview/paneview.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,8 +68,8 @@
cursor: pointer;
}

&:focus,
&:focus-within {
&:focus-visible,
&:has(:focus-visible) {
&:before {
position: absolute;
top: 0;
Expand All @@ -94,8 +94,8 @@
position: relative;
outline: none;

&:focus,
&:focus-within {
&:focus-visible,
&:has(:focus-visible) {
&:before {
position: absolute;
top: 0;
Expand Down
Loading