Skip to content

Add warning for parallel builds #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
duncanpo merged 2 commits into from
Mar 25, 2026
Merged

Add warning for parallel builds #244

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1b7319e
Add warning for parallel builds
sameagen-MW Mar 25, 2026
1add839
Update warning message for parallel builds
sameagen-MW Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions instrumentation/buildtool/+matlab/+buildtool/+plugins/OpenTelemetryPlugin.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,17 @@

methods(Access = protected)
function runBuild(plugin, pluginData)
% Warn users that tasks on workers will not emit telemetry data
% if a pool is open.
%
% Imperfect detection of parallel builds but
% the impact of a false positive is very low
p = gcp("nocreate");
if ~isempty(p)
warning("opentelemetry:buildtool:OpenTelemetryPlugin:NoParallelEmit", ...
"Tasks run on parallel workers will not emit telemetry data");
Copy link
Copy Markdown
Member

@mw-hrastega mw-hrastega Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of suggestions:

  • Let's not use future tense.
  • Warnings should end in a period.

Proposed edit:

Tasks executed on parallel workers do not emit telemetry data.

Question: Does a task that runs on a client (e.g., a TestTask instance) emit data?

Copy link
Copy Markdown
Member Author

@sameagen-MW sameagen-MW Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Houman, I like your proposal and will update the message. Tasks that run on the client will indeed emit data.

Copy link
Copy Markdown
Member

@mw-hrastega mw-hrastega Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Sam.

end

% Configure by attaching to span if passed in via environment
% variable, and propagating baggage
configureOTel();
Expand Down Expand Up @@ -56,10 +67,6 @@ function runBuild(plugin, pluginData)
end

function runTask(plugin, pluginData)
% TODO:
% - buildtool.task.outputs
% - buildtool.task.inputs

% Definitions
task = pluginData.TaskGraph.Tasks;
taskName = pluginData.Name;
Expand Down
Loading