-
Notifications
You must be signed in to change notification settings - Fork 91
Switch to proxy URL to handle API requests to demo, #PG-5029 #876
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,111 @@ | ||
| <?php | ||
| /** | ||
| * Piwik - Open source web analytics | ||
| * | ||
| * @link http://piwik.org | ||
| * @license http://www.gnu.org/licenses/gpl-3.0.html GPL v3 or later | ||
| */ | ||
|
|
||
| namespace helpers; | ||
|
|
||
| /** | ||
| * Proxy for demo.matomo.cloud, allows us to make single origin requests by doing them through this class | ||
| */ | ||
| class DemoProxy | ||
| { | ||
|
|
||
| private const MATOMO_SWAGGER_PROXY_TARGET = 'https://demo.matomo.cloud'; | ||
| private const DEMO_AUTHORIZATION_HEADER = 'Bearer anonymous'; | ||
|
|
||
| /** | ||
| * Fetches a demo API GET response and returns the body and status code. | ||
| * | ||
| * @param string $url Demo API URL to request. | ||
| * @return array{body: string, statusCode: int} | ||
| */ | ||
| public static function get(string $url): array | ||
| { | ||
| $context = self::createContext(); | ||
| $proxiedResponse = self::fetchResponse($url, $context); | ||
| $statusCode = self::parseStatusCode($proxiedResponse['responseHeaders']); | ||
|
|
||
| return [ | ||
| 'body' => $proxiedResponse['body'], | ||
| 'statusCode' => $statusCode, | ||
| ]; | ||
| } | ||
|
|
||
| /** | ||
| * Builds a validated demo API URL for proxying. | ||
| * | ||
| * @param string $path Relative request path. | ||
| * @param array $queryParams Query parameters to append to the URL. | ||
| * @return string The validated absolute demo API URL. | ||
| * @throws \InvalidArgumentException If the path is not index.php. | ||
| * @throws \InvalidArgumentException If the module query parameter is not API. | ||
| */ | ||
| public static function buildValidatedApiUrl(string $path, array $queryParams): string | ||
| { | ||
| $normalizedPath = trim($path, '/'); | ||
| if ($normalizedPath !== 'index.php') { | ||
| throw new \InvalidArgumentException('Path must be index.php'); | ||
| } | ||
|
|
||
| if (($queryParams['module'] ?? null) !== 'API') { | ||
| throw new \InvalidArgumentException('Module must be API'); | ||
| } | ||
|
|
||
| $targetUrl = rtrim(self::MATOMO_SWAGGER_PROXY_TARGET, '/') . '/' . $normalizedPath; | ||
| $query = http_build_query($queryParams); | ||
|
|
||
| if ($query !== '') { | ||
| $targetUrl .= '?' . $query; | ||
| } | ||
|
|
||
| return $targetUrl; | ||
| } | ||
|
|
||
| private static function createContext() | ||
| { | ||
| return stream_context_create([ | ||
| 'http' => [ | ||
| 'method' => 'GET', | ||
| 'header' => self::buildHeaders(), | ||
| 'ignore_errors' => true, | ||
| 'timeout' => 30, | ||
| ], | ||
| ]); | ||
| } | ||
|
|
||
| private static function buildHeaders(): string | ||
| { | ||
| return 'Authorization: ' . self::DEMO_AUTHORIZATION_HEADER; | ||
| } | ||
|
|
||
| /** | ||
| * @return array{body: string, responseHeaders: array} | ||
| */ | ||
| private static function fetchResponse(string $url, $context): array | ||
| { | ||
| $body = @file_get_contents($url, false, $context); | ||
| if ($body === false) { | ||
| throw new \RuntimeException('Could not proxy HTTP request'); | ||
| } | ||
|
|
||
| return [ | ||
| 'body' => $body, | ||
| 'responseHeaders' => $http_response_header ?? [], | ||
| ]; | ||
| } | ||
|
|
||
| private static function parseStatusCode(array $responseHeaders): int | ||
| { | ||
| $statusLine = $responseHeaders[0] ?? ''; | ||
|
|
||
| if (preg_match('#^HTTP/\S+\s+(\d{3})#', $statusLine, $matches)) { | ||
| return (int) $matches[1]; | ||
| } | ||
|
|
||
| return 200; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should add a try/catch here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, I also realised we return errors with a 200 OK? At the moment it doesn't break anything in Swagger, technically we could catch in the proxy and throw something else