harden marketplace link generation so that a stale idsite cannot persist#24401
Open
nathangavin wants to merge 4 commits into
Open
harden marketplace link generation so that a stale idsite cannot persist#24401nathangavin wants to merge 4 commits into
nathangavin wants to merge 4 commits into
Conversation
Contributor
|
If you don't want this PR to be closed automatically in 28 days then you need to assign the label 'Do not close'. |
github-actions
Bot
added
the
Stale
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A customer report shows that its possible for various marketplace links are able to have stale idsites present in the generated URLs. This fix addresses that by doing a check against idsites that would be inserted into the URL, and providing fallback values if that idsite is not valid.
Checklist
Review