Implementing more test cases

Author: snake14

Annotations/AnnotationGenerator.php

@@ -1561,12 +1561,13 @@ public function wrapStringWithQuotes(string $string, string $type, string $quote
      */
     public function shouldIncludeDefault(string $type, string $default = NoDefaultValue::class): bool
     {
-        if ($default === NoDefaultValue::class) {
-            return false;
-        }
-
-        // Don't use true or false for default if it's not a boolean type
-        if ($type !== 'boolean' && in_array(strtolower($default), ['false', 'true'])) {
+        if (
+            $default === NoDefaultValue::class
+            || ($type === 'number' && !is_numeric($default))
+            || ($type === 'integer' && !\ctype_digit($default))
+            || ($type !== 'string' && $default === '')
+            || ($type !== 'boolean' && in_array(strtolower($default), ['false', 'true']))
+        ) {
             return false;
         }
 

OpenApiDocs.php

@@ -15,6 +15,7 @@ class OpenApiDocs extends \Piwik\Plugin
     public const GENERATED_ANNOTATIONS_PATH = '/tmp/annotations/';
     public const EXAMPLE_RESPONSES_PATH = '/tmp/responses/';
     public const GENERATED_SPECS_PATH = '/tmp/specs/';
+    public const AVAILABLE_PROPERTY_TYPES = ['string', 'number', 'integer', 'boolean', 'array', 'object', 'null'];
 
     public function registerEvents()
     {