Added cloud pr suggestion, check if path exists and is writable

lachiebol · lachiebol · commit 3cda6cd58e74 · 2026-04-08T14:53:18.000+12:00
diff --git a/Specs/PathResolver.php b/Specs/PathResolver.php
@@ -98,6 +98,10 @@ private function getSharedArtifactDirectory(string $sharedSubdirectory): ?string
             return null;
         }
 
+        if (!is_dir($sharedBasePath) || !is_writable($sharedBasePath)) {
+            return null;
+        }
+
         return rtrim($sharedBasePath, '/\\') . self::SHARED_BASE_SUBDIRECTORY . ltrim(substr($sharedSubdirectory, strlen(self::SHARED_BASE_SUBDIRECTORY)), '/\\');
     }
 

Original file line number	Diff line number	Diff line change
`@@ -98,6 +98,10 @@ private function getSharedArtifactDirectory(string $sharedSubdirectory): ?string`
`98`	`98`	`return null;`
`99`	`99`	`}`
`100`	`100`
	`101`	`+ if (!is_dir($sharedBasePath) \|\| !is_writable($sharedBasePath)) {`
	`102`	`+ return null;`
	`103`	`+ }`
	`104`	`+`
`101`	`105`	`return rtrim($sharedBasePath, '/\\') . self::SHARED_BASE_SUBDIRECTORY . ltrim(substr($sharedSubdirectory, strlen(self::SHARED_BASE_SUBDIRECTORY)), '/\\');`
`102`	`106`	`}`
`103`	`107`