Skip to content

Commit 46c3cb2

Browse files
committed
Fix codex review comments
1 parent 20758fc commit 46c3cb2

3 files changed

Lines changed: 3 additions & 4 deletions

File tree

Controller.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ class Controller extends \Piwik\Plugin\ControllerAdmin
1818
{
1919
public function swagger(): string
2020
{
21-
Piwik::checkUserHasSuperUserAccess();
21+
Piwik::checkUserHasSomeViewAccess();
2222

2323
$view = new View('@OpenApiDocs/swagger');
2424
$this->setBasicVariablesView($view);

OpenApiDocs.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,6 @@ public function getStylesheetFiles(&$stylesheets): void
3333
{
3434
$stylesheets[] = 'plugins/OpenApiDocs/vue/lib/swagger-ui/swagger-ui.css';
3535
$stylesheets[] = 'plugins/OpenApiDocs/vue/src/SwaggerPage/swagger-ui-overrides.css';
36-
$stylesheets[] = 'plugins/OpenApiDocs/vue/dist/OpenApiDocs.css';
3736
}
3837

3938
public function getJsFiles(&$jsFiles): void

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,14 +5,14 @@
55
Allow generating OpenAPI documentation for the Matomo public APIs.
66

77
## Frontend assets
8-
Swagger UI is managed via npm inside [vue/package.json](/home/lachlan/matomo-code/matomo_5x-dev/plugins/OpenApiDocs/vue/package.json). The plugin runtime does not load Swagger UI from `node_modules`; instead, the needed distributable files are synced into `vue/lib/swagger-ui/`.
8+
Swagger UI is managed via npm inside [vue/package.json](/vue/package.json). The plugin runtime does not load Swagger UI from `node_modules`; instead, the needed distributable files are synced into `vue/lib/swagger-ui/`.
99

1010
Typical workflow:
1111
- Run `npm install` in `plugins/OpenApiDocs/vue`.
1212
- Run `npm run sync-swagger-ui` in `plugins/OpenApiDocs/vue` after adding or updating `swagger-ui-dist`.
1313
- Run `ddev matomo:console vue:build OpenApiDocs` after changing Vue source.
1414

15-
The plugin-specific Swagger overrides live in [vue/src/SwaggerPage/swagger-ui-overrides.css](/home/lachlan/matomo-code/matomo_5x-dev/plugins/OpenApiDocs/vue/src/SwaggerPage/swagger-ui-overrides.css).
15+
The plugin-specific Swagger overrides live in [vue/src/SwaggerPage/swagger-ui-overrides.css](/vue/src/SwaggerPage/swagger-ui-overrides.css).
1616

1717
## Dependencies
1818
This plugin had its vendored dependencies scoped using [matomo scoper](https://github.com/matomo-org/matomo-scoper). This means that composer packages are prefixed so that they won't conflict with the same libraries used by other plugins.

0 commit comments

Comments
 (0)