Skip to content

Commit 8bf4d34

Browse files
committed
Remove stale test case that has no purpose now
1 parent 2231750 commit 8bf4d34

1 file changed

Lines changed: 10 additions & 27 deletions

File tree

tests/Integration/MenuTest.php

Lines changed: 10 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,9 @@
1111

1212
namespace Piwik\Plugins\ApiReference\tests\Integration;
1313

14+
use Piwik\Access;
1415
use Piwik\Cache;
16+
use Piwik\Container\StaticContainer;
1517
use Piwik\Menu\MenuAdmin;
1618
use Piwik\Plugin\Manager;
1719
use Piwik\Tests\Framework\Fixture;
@@ -52,36 +54,17 @@ public function tearDown(): void
5254

5355
public function testConfigureAdminMenuAddsApiItemForViewAccess(): void
5456
{
55-
FakeAccess::clearAccess(
56-
$superUser = false,
57-
$idSitesAdmin = [0],
58-
$idSitesView = [1],
59-
$identity = 'viewAccessUser'
60-
);
57+
$originalAccess = StaticContainer::getContainer()->get(Access::class);
58+
StaticContainer::getContainer()->set(Access::class, new FakeAccess(false, [0], [1], 'viewAccessUser'));
6159

62-
$items = $this->buildConfiguredMenu()->getMenu();
60+
try {
61+
$items = $this->buildConfiguredMenu()->getMenu();
6362

64-
$this->assertArrayHasKey('CorePluginsAdmin_MenuPlatform', $items);
65-
$this->assertArrayHasKey('General_API', $items['CorePluginsAdmin_MenuPlatform']);
66-
}
67-
68-
public function testConfigureAdminMenuSkipsApiItemWithoutViewAccess(): void
69-
{
70-
FakeAccess::clearAccess(
71-
$superUser = false,
72-
$idSitesAdmin = [],
73-
$idSitesView = [],
74-
$identity = 'noAccessUser'
75-
);
76-
77-
$items = $this->buildConfiguredMenu()->getMenu();
78-
79-
if (!isset($items['CorePluginsAdmin_MenuPlatform'])) {
80-
$this->assertArrayNotHasKey('CorePluginsAdmin_MenuPlatform', $items);
81-
return;
63+
$this->assertArrayHasKey('CorePluginsAdmin_MenuPlatform', $items);
64+
$this->assertArrayHasKey('General_API', $items['CorePluginsAdmin_MenuPlatform']);
65+
} finally {
66+
StaticContainer::getContainer()->set(Access::class, $originalAccess);
8267
}
83-
84-
$this->assertArrayNotHasKey('General_API', $items['CorePluginsAdmin_MenuPlatform']);
8568
}
8669

8770
private function buildConfiguredMenu(): MenuAdmin

0 commit comments

Comments
 (0)