Catching invalid XML errors when grabbing xml from response cache

lachiebol · lachiebol · commit c5fb38d55877 · 2026-02-12T15:50:44.000+13:00
diff --git a/Annotations/AnnotationGenerator.php b/Annotations/AnnotationGenerator.php
@@ -941,7 +941,11 @@ protected function getCachedExampleResponseFile(string $pluginName, string $meth
         }
 
         if (!$rawResult && $format === 'xml') {
-            $exampleContents = json_encode($this->convertExampleXmlToObject($exampleContents));
+            try {
+                $exampleContents = json_encode($this->convertExampleXmlToObject($exampleContents));
+            } catch (\Exception $e) {
+                return '';
+            }
         }
 
         // Unless set otherwise, make sure that the example is around the max allowed characters. If raw, don't bother.

Original file line number	Diff line number	Diff line change
`@@ -941,7 +941,11 @@ protected function getCachedExampleResponseFile(string $pluginName, string $meth`
`941`	`941`	`}`
`942`	`942`
`943`	`943`	`if (!$rawResult && $format === 'xml') {`
`944`		`- $exampleContents = json_encode($this->convertExampleXmlToObject($exampleContents));`
	`944`	`+ try {`
	`945`	`+ $exampleContents = json_encode($this->convertExampleXmlToObject($exampleContents));`
	`946`	`+ } catch (\Exception $e) {`
	`947`	`+ return '';`
	`948`	`+ }`
`945`	`949`	`}`
`946`	`950`
`947`	`951`	`// Unless set otherwise, make sure that the example is around the max allowed characters. If raw, don't bother.`