fix tests

Author: lachiebol

Specs/PathResolver.php

@@ -98,13 +98,18 @@ private function getSharedArtifactDirectory(string $sharedSubdirectory): ?string
             return null;
         }
 
-        if (!is_dir($sharedBasePath) || !is_writable($sharedBasePath)) {
+        if (!$this->isUsableSharedBasePath($sharedBasePath)) {
             return null;
         }
 
         return rtrim($sharedBasePath, '/\\') . self::SHARED_BASE_SUBDIRECTORY . ltrim(substr($sharedSubdirectory, strlen(self::SHARED_BASE_SUBDIRECTORY)), '/\\');
     }
 
+    protected function isUsableSharedBasePath(string $sharedBasePath): bool
+    {
+        return is_dir($sharedBasePath) && is_writable($sharedBasePath);
+    }
+
     private function getStaticContainer(): ?Container
     {
         try {

tests/Unit/Specs/PathResolverTest.php

@@ -35,7 +35,7 @@ public function testReturnsPluginLocalPathsWhenCloudIsDisabled(): void
 
     public function testReturnsSharedPathsWhenCloudIsEnabledAndDistributedCachePathExists(): void
     {
-        $resolver = new PathResolver('/plugins/OpenApiDocs', true, $this->buildContainerStub(true, '/cache/distributed'));
+        $resolver = $this->buildPathResolverWithSharedPathValidationResult(true, '/cache/distributed', true);
 
         $this->assertSame('/cache/distributed/OpenApiDocs/specs/', $resolver->getSpecDirectory());
         $this->assertSame('/cache/distributed/OpenApiDocs/annotations/', $resolver->getAnnotationsDirectory());
@@ -62,7 +62,7 @@ public function testFallsBackToPluginLocalPathsWhenCloudCachePathIsEmpty(): void
 
     public function testBuildsFilePathsUsingExpectedNamingConventions(): void
     {
-        $resolver = new PathResolver('/plugins/OpenApiDocs', true, $this->buildContainerStub(true, '/cache/distributed/'));
+        $resolver = $this->buildPathResolverWithSharedPathValidationResult(true, '/cache/distributed/', true);
 
         $this->assertSame(
             '/cache/distributed/OpenApiDocs/specs/CustomAlerts_openapi_spec_v2.0.0.yaml',
@@ -101,4 +101,21 @@ private function buildContainerStub(bool $hasDistributedCachePath, string $distr
 
         return $container;
     }
+
+    private function buildPathResolverWithSharedPathValidationResult(
+        bool $hasDistributedCachePath,
+        string $distributedCachePath,
+        bool $isUsableSharedBasePath
+    ): PathResolver {
+        $resolver = $this->getMockBuilder(PathResolver::class)
+            ->setConstructorArgs(['/plugins/OpenApiDocs', true, $this->buildContainerStub($hasDistributedCachePath, $distributedCachePath)])
+            ->onlyMethods(['isUsableSharedBasePath'])
+            ->getMock();
+
+        $resolver->method('isUsableSharedBasePath')
+            ->with(trim($distributedCachePath))
+            ->willReturn($isUsableSharedBasePath);
+
+        return $resolver;
+    }
 }