Skip to content

Adding more test cases and making more improvements#11

Merged
snake14 merged 13 commits into
5.x-devfrom
adding-more-test-cases
Sep 29, 2025
Merged

Adding more test cases and making more improvements#11
snake14 merged 13 commits into
5.x-devfrom
adding-more-test-cases

Conversation

@snake14
Copy link
Copy Markdown
Contributor

@snake14 snake14 commented Sep 26, 2025

Description

Improvements made while working annotating the latest plugins and adding SwaggerUI to the developer documentation. The biggest change is that the plugin now saves all generated files in its own tmp/ directory instead of creating sub-directories in each plugin.

Issue No

  • PG-4502
  • PG-4397

Steps to Replicate the Issue

Not really applicable since it was mostly internal improvements, like adding more test cases and documenting code. I guess you could run the annotation and spec generation commands to see that the files are now saved in plugins/OpenApiDocs/tmp/, including caching example responses.
Here are examples of running the command:
ddev matomo:console openapidocs:generate-annotations --plugin=UsersFlow --not-dry-run
ddev matomo:console openapidocs:generate-spec-file --plugin=UsersFlow --not-dry-run

Checklist

  • [✔] Tested locally or on demo2/demo3?
  • [✔] New test case added/updated?
  • [NA] Are all newly added texts included via translation?
  • [NA] Are text sanitized properly? (Eg use of v-text v/s v-html for vue)
  • [✖] Version bumped?

@snake14 snake14 marked this pull request as ready for review September 28, 2025 23:05
@snake14 snake14 added the Needs Review For pull requests that need a code review. label Sep 28, 2025
@snake14 snake14 requested a review from a team September 28, 2025 23:06
Copy link
Copy Markdown

@james-hill-matomo james-hill-matomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on local, still works :)

Comment thread Annotations/AnnotationGenerator.php Outdated
Copy link
Copy Markdown
Contributor

@AltamashShaikh AltamashShaikh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, I can see annotation and spec file in tmp directory 👍

@snake14 snake14 merged commit fe9b540 into 5.x-dev Sep 29, 2025
7 checks passed
@snake14 snake14 deleted the adding-more-test-cases branch September 29, 2025 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs Review For pull requests that need a code review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants