Skip to content

Improve unit test coverage and fix minor bug#14

Merged
snake14 merged 12 commits into
5.x-devfrom
PG-4540-improve-unit-tests
Oct 6, 2025
Merged

Improve unit test coverage and fix minor bug#14
snake14 merged 12 commits into
5.x-devfrom
PG-4540-improve-unit-tests

Conversation

@snake14
Copy link
Copy Markdown
Contributor

@snake14 snake14 commented Oct 2, 2025

Description

Add more unit tests and fix a few issues in the annotation generation. If you ignore the tests/Resources/ directory, there weren't that many changes.

Issue No

PG-4601

Steps to Replicate the Issue

  1. Not much to test. I guess you could run the annotation generator for a plugin and look at the annotations.

Checklist

  • [✔] Tested locally or on demo2/demo3?
  • [✔] New test case added/updated?
  • [NA] Are all newly added texts included via translation?
  • [NA] Are text sanitized properly? (Eg use of v-text v/s v-html for vue)
  • [NA] Version bumped?

@snake14 snake14 marked this pull request as ready for review October 6, 2025 04:46
@snake14 snake14 added the Needs Review For pull requests that need a code review. label Oct 6, 2025
@snake14 snake14 requested a review from a team October 6, 2025 04:48
Copy link
Copy Markdown
Contributor

@AltamashShaikh AltamashShaikh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay to me

@snake14 snake14 merged commit b5ecf24 into 5.x-dev Oct 6, 2025
7 checks passed
@snake14 snake14 deleted the PG-4540-improve-unit-tests branch October 6, 2025 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs Review For pull requests that need a code review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants