Add doc parser code change#16
Merged
Merged
Conversation
james-hill-matomo
approved these changes
Oct 9, 2025
james-hill-matomo
left a comment
james-hill-matomo
left a comment
There was a problem hiding this comment.
LGTM. Tested by running annotations on this branch and 5.x-dev, and saw some minor changes between output. This shows that it is working, and the changes are all fine.
snake14
added a commit
that referenced
this pull request
Oct 9, 2025
* Add the phpDocumentor dependency * Add doc parser code change (#16) * Make code change after dependency update * Making a few more adjustments to switch dependencies * Try adding bootstrap to alias classes for PHPStan * Try some changes * Revert "Try some changes" This reverts commit 43b085b. * Revert "Try adding bootstrap to alias classes for PHPStan" This reverts commit 1626077. * Adding autoload to test file * Trying simplified bootstrap for PHPStan
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Switch from using Matomo dependency to scoped dependency for parsing docblocks. This is dependent on #15 .
The main reason for these two PRs is because the plugin was dependent on a dev-only dependency from the main application, so we can't rely on that always being available. This switches to a pinned version of a production dependency which is scoped within this plugin and will always be available.
Testing isn't really needed, but you can run the command to annotate a plugin if you like.