Added endpoint that can return single spec files, #PG-4593#25
Merged
Conversation
| { | ||
| Piwik::checkUserHasSomeViewAccess(); | ||
|
|
||
| if (strtolower($format) !== 'json') { |
Contributor
There was a problem hiding this comment.
We should also add a validation for $spec, it should be an valid pluginName
Contributor
Author
There was a problem hiding this comment.
@AltamashShaikh I've changed that, also removed the single spec file logic from the endpoint. I don't think it's really required anymore.
AltamashShaikh
requested changes
Mar 18, 2026
| * @throws \Exception If the file is missing, unreadable, or contains invalid JSON. | ||
| */ | ||
| public function getMatomoOpenApiSpec(string $format = 'json'): array | ||
| public function getOpenApiSpec(string $spec, string $format = 'json'): array |
Contributor
There was a problem hiding this comment.
@lachiebol Should we change the parameter name to pluginName from spec ?
Suggested change
| public function getOpenApiSpec(string $spec, string $format = 'json'): array | |
| public function getOpenApiSpec(string $plugin, string $format = 'json'): array |
Contributor
There was a problem hiding this comment.
This comment is optional
Contributor
Author
There was a problem hiding this comment.
@AltamashShaikh pluginName sounds more accurate, changed that
AltamashShaikh
previously approved these changes
Mar 18, 2026
Contributor
AltamashShaikh
left a comment
There was a problem hiding this comment.
Left 1 optional comment, looks good to me
Contributor
Author
|
Tests failed just fixing... |
AltamashShaikh
previously approved these changes
Mar 18, 2026
AltamashShaikh
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Can now retrieve all spec files with 'matomo' or a specific plugin with it's name
Issue No
Steps to Replicate the Issue
Checklist