Add examples for try it out, #PG-5178#38
Merged
Conversation
lachiebol
commented
May 15, 2026
Contributor
Author
There was a problem hiding this comment.
New examples, have done a quick sense check. But if anything doesn't look right let me know
lachiebol
commented
May 15, 2026
| foreach ($typeHints as $typePart) { | ||
| $typePart = trim($typePart, ' ()'); | ||
| $normalisedType = $this->getOpenApiTypeFromPhpType($typePart); | ||
| $normalisedType = $this->hasSpecificArrayShape($typePart) ? 'array' : $this->getOpenApiTypeFromPhpType($typePart); |
Contributor
Author
There was a problem hiding this comment.
If it's a complex array type I'm just leaving it for now. When I implement POST this can be changed
lachiebol
commented
May 15, 2026
| if ( | ||
| !is_array($example) | ||
| || !$this->isBasicExampleArray($example) | ||
| || !$this->supportsBasicArrayExample($typesMap) |
Contributor
Author
There was a problem hiding this comment.
Same here: will remove this logic when adding POST. At the moment it prevents complex param examples from coming through
Contributor
Author
|
@AltamashShaikh Will address these concerns in POST request PR |
AltamashShaikh
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Description
To get updated specs:
core:run-scheduled-tasks "Piwik\Plugins\OpenApiDocs\Tasks.generateConfiguredPluginSpecs" --forceThen you can verify in the UI tab
Issue No
Steps to Replicate the Issue
Checklist