Skip to content

Pg 5208 enable generation by default#45

Merged
lachiebol merged 8 commits into
5.x-devfrom
PG-5208-enable-generation-by-default
May 22, 2026
Merged

Pg 5208 enable generation by default#45
lachiebol merged 8 commits into
5.x-devfrom
PG-5208-enable-generation-by-default

Conversation

@lachiebol
Copy link
Copy Markdown
Contributor

@lachiebol lachiebol commented May 21, 2026

Description

Should now be able to run the task with no config option set.

This should disable:

[ApiReference]
enable_spec_generation_task = 0

Issue No

Steps to Replicate the Issue

Checklist

  • [✔/✖] Tested locally or on demo2/demo3?
  • [✔/✖/NA] New test case added/updated?
  • [✔/✖/NA] Are all newly added texts included via translation?
  • [✔/✖/NA] Are text sanitized properly? (Eg use of v-text v/s v-html for vue)
  • [✔/✖/NA] Version bumped?
  • [✔/✖/NA] Documentation updated?

@lachiebol lachiebol requested a review from AltamashShaikh May 21, 2026 08:37
@lachiebol lachiebol added the Needs Review For pull requests that need a code review. label May 21, 2026
Comment thread Configuration.php Outdated
<?php

/**
* Copyright (C) InnoCraft Ltd - All rights reserved.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lachiebol This needs to be changed since we have a GPL license for this plugin.

Copy link
Copy Markdown
Contributor

@AltamashShaikh AltamashShaikh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 left 1 comment

@lachiebol lachiebol requested a review from AltamashShaikh May 21, 2026 22:30
@lachiebol
Copy link
Copy Markdown
Contributor Author

@AltamashShaikh Good spot! Fixed that

@lachiebol lachiebol merged commit e11966b into 5.x-dev May 22, 2026
7 checks passed
@lachiebol lachiebol deleted the PG-5208-enable-generation-by-default branch May 22, 2026 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs Review For pull requests that need a code review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants