Skip to content

Pg 4396 add workflows#7

Merged
snake14 merged 12 commits into
PG-4396-generate-oa-annotationsfrom
PG-4396-add-workflows
Sep 2, 2025
Merged

Pg 4396 add workflows#7
snake14 merged 12 commits into
PG-4396-generate-oa-annotationsfrom
PG-4396-add-workflows

Conversation

@snake14
Copy link
Copy Markdown
Contributor

@snake14 snake14 commented Aug 31, 2025

Description

Adding workflows to this plugin.

Comment thread phpstan.neon
- vendor/*
- github-action-tests
- scoper.inc.php
- Specs/SpecGenerator.php
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is temporary. I'm hoping that the errors in that class will go away once I've scoped the composer dependencies.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A comment in the code saying that would be nice. Nitpick.

@snake14 snake14 marked this pull request as ready for review September 1, 2025 01:30
@snake14 snake14 added the Needs Review For pull requests that need a code review. label Sep 1, 2025
@snake14 snake14 requested a review from a team September 1, 2025 01:30
@snake14
Copy link
Copy Markdown
Contributor Author

snake14 commented Sep 1, 2025

@james-hill-matomo @AltamashShaikh Is this alright to merge?

@snake14 snake14 changed the base branch from 5.x-dev to PG-4396-generate-oa-annotations September 1, 2025 23:11
Copy link
Copy Markdown

@james-hill-matomo james-hill-matomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread phpstan.neon
- vendor/*
- github-action-tests
- scoper.inc.php
- Specs/SpecGenerator.php
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A comment in the code saying that would be nice. Nitpick.

@snake14 snake14 merged commit 1514976 into PG-4396-generate-oa-annotations Sep 2, 2025
7 checks passed
@snake14 snake14 deleted the PG-4396-add-workflows branch September 2, 2025 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs Review For pull requests that need a code review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants