Finalising annotation generation before annotating first plugins#9
Merged
Conversation
Contributor
AltamashShaikh
left a comment
There was a problem hiding this comment.
Left couple of comments, rest looks good to me.
AltamashShaikh
approved these changes
Sep 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Make various improvements in the annotation generation including fixing some issues. This will allow most examples to be included and most responses typed.
Issue No
PG-4544
Steps to Replicate the Issue
ddev matomo:console openapidocs:generate-annotations --plugin=CustomReports --not-dry-runddev matomo:console openapidocs:generate-spec-file --plugin=CustomReports --not-dry-runplugins/CustomReports/OpenApi/Specs/CustomReports_v1.0.0.jsonand preview in PHPStorm to see the SwaggerUI presentation with almost all parameters and responses fully typed (A CustomReports PR is making a few changes to allow even better results).Checklist