Refactored CustomAlerts UI to support selection of medium to send alert, #PG-4530#208
Refactored CustomAlerts UI to support selection of medium to send alert, #PG-4530#208AltamashShaikh merged 3 commits into5.x-devfrom
Conversation
|
@james-hill-matomo @snake14 I have to create a new PR from this branch to add Slack as an option. |
james-hill-matomo
left a comment
There was a problem hiding this comment.
Error messages not 100% consistent - e.g. "Report mediums must not be empty" shows when the UI box is labelled "Send via"
Quite a few bad UX things going on, but out of scope of this ticket.
I wasn't able to test what happens if you add a phone number and then choose "Send via" email only - is that supported OK?
| <rule ref="Generic.Files.LineLength"> | ||
| <properties> | ||
| <property name="lineLimit" value="250" /> | ||
| <property name="lineLimit" value="260" /> |
There was a problem hiding this comment.
yaa it was giving an error of 255 characters, so increased it to 260
It would be set to empty if the medium is not set - https://github.com/matomo-org/plugin-CustomAlerts/pull/208/files#diff-289a75deac5516af6414cbbad6082c750fb8b192830f6b8fdf4348a97091716dR188 |

Description
Refactored CustomAlerts UI to support selection of medium to send alert
Issue No
#PG-4530
Steps to Replicate the Issue
emailMEandadditionalEmailsparameter is empty.Checklist