Adds test for CustomAlerts via MSTeams, #PG-4671#4
Merged
AltamashShaikh merged 14 commits intoPG-4671-msteamsfrom Dec 15, 2025
Merged
Adds test for CustomAlerts via MSTeams, #PG-4671#4AltamashShaikh merged 14 commits intoPG-4671-msteamsfrom
AltamashShaikh merged 14 commits intoPG-4671-msteamsfrom
Conversation
Contributor
Author
|
The tests will work only if we merge the CustomAlerts PR |
james-hill-matomo
approved these changes
Nov 25, 2025
Comment on lines
+38
to
+43
| $this->assertEquals([ | ||
| ['key' => 'email', 'value' => 'CustomAlerts_MediumEmail', 'disabled' => false], | ||
| ['key' => 'mobile', 'value' => 'CustomAlerts_MediumMobile', 'disabled' => false], | ||
| ['key' => 'slack', 'value' => 'CustomAlerts_MediumSlack', 'disabled' => true], | ||
| ['key' => 'teams', 'value' => 'CustomAlerts_MediumMicrosoftTeams', 'disabled' => false], | ||
| ], CustomAlerts::getReportMediumOptions()); |
There was a problem hiding this comment.
Can we change this to assertArrayIncludes and just check for teams, so we don't have to fix the test every time we add a new method? Nitpick, although I had to do just that in the other plugins recently...
Contributor
Author
There was a problem hiding this comment.
Done changed to contains 👍
Base automatically changed from
PG-4671-msteams-add-tests
to
PG-4671-msteams
November 26, 2025 05:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds test for CustomAlerts via MSTeams
Fixes: #PG-4671
Requires: matomo-org/plugin-CustomAlerts#220
Checklist
Review