Skip to content

Commit ad666c0

Browse files
Changes to work on all branches and reduced the phpstan level to 5 for both created and updated
1 parent 700046d commit ad666c0

3 files changed

Lines changed: 8 additions & 9 deletions

File tree

.git-hooks-matomo/pre-push

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ REPO_DIR="$(git rev-parse --show-toplevel)"
2020
echo "Running pre-commit hook in repo: $REPO_DIR"
2121

2222
if [[ "$REPO_DIR" =~ /plugins/(.*) ]]; then
23-
PLUGIN_PATH="plugins/${BASH_REMATCH[1]}"
23+
PLUGIN_PATH=${REPO_DIR}
2424
else
2525
echo "Not a plugin, not running any further checks"
2626
exit 1
@@ -64,15 +64,15 @@ STATUS=0
6464

6565
### Run PHPStan on newly created files. ###
6666

67-
PHPSTAN_CREATED_CONFIG=${MATOMO_DIR}/phpstan/phpstan.created.neon
67+
PHPSTAN_CREATED_CONFIG=phpstan/phpstan.created.neon
68+
BRANCH_NAME=$(git branch --show-current)
6869
if [[ -f "$PHPSTAN_CREATED_CONFIG" ]]; then
69-
CHANGED_FILES=$(git diff --name-only 5.x-dev...HEAD --diff-filter=A | grep '\.php$' || true)
70+
CHANGED_FILES=$(git diff --name-only ${BRANCH_NAME} --diff-filter=A | grep '\.php$' || true)
7071
if [ -z "$CHANGED_FILES" ]; then
7172
echo "No created PHP files"
7273
else
7374
echo "Running PHPstan at a very high level on new files"
74-
CHANGED_FILES=`echo "$CHANGED_FILES" | sed -e 's/^\(.*\)$/"\1"/' | xargs -I{} echo "${MATOMO_DIR}/${PLUGIN_PATH}/{}"`
75-
echo "$CHANGED_FILES" | xargs $COMMAND analyse -c ${MATOMO_DIR}/${PLUGIN_PATH}/${PHPSTAN_CREATED_CONFIG} || STATUS=1
75+
echo "$CHANGED_FILES" | xargs $COMMAND analyse -c ${PLUGIN_PATH}/${PHPSTAN_CREATED_CONFIG} || STATUS=1
7676
fi
7777
fi
7878

@@ -81,12 +81,11 @@ fi
8181
### Run PHPStan on modified files. ###
8282
PHPSTAN_MODIFIED_CONFIG=phpstan/phpstan.modified.neon
8383
if [[ -f "$PHPSTAN_MODIFIED_CONFIG" ]]; then
84-
CHANGED_FILES=$(git diff --name-only 5.x-dev...HEAD --diff-filter=CM | grep '\.php$' || true)
84+
CHANGED_FILES=$(git diff --name-only ${BRANCH_NAME} --diff-filter=CM | grep '\.php$' || true)
8585
if [ -z "$CHANGED_FILES" ]; then
8686
echo "No changed PHP files"
8787
else
8888
echo "Running PHPstan on modified files"
89-
CHANGED_FILES=`echo "$CHANGED_FILES" | sed -e 's/^\(.*\)$/"\1"/' | xargs -I{} echo "${PLUGIN_PATH}/{}"`
9089
echo "$CHANGED_FILES" | xargs $COMMAND analyse -c ${PLUGIN_PATH}/${PHPSTAN_MODIFIED_CONFIG} || STATUS=1
9190
fi
9291
fi

phpstan/phpstan.created.neon

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
includes:
22
- ../phpstan.neon
33
parameters:
4-
level: 8
4+
level: 5
55
tmpDir: /tmp/phpstan/Slack/created

phpstan/phpstan.modified.neon

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
includes:
22
- ../phpstan.neon
33
parameters:
4-
level: 1
4+
level: 5
55
tmpDir: /tmp/phpstan/Slack/modified

0 commit comments

Comments
 (0)