Update CustomAlerts to include Matomo domain with idSite, #PG-4676#20
Merged
AltamashShaikh merged 3 commits into5.x-devfrom Oct 17, 2025
Merged
Update CustomAlerts to include Matomo domain with idSite, #PG-4676#20AltamashShaikh merged 3 commits into5.x-devfrom
AltamashShaikh merged 3 commits into5.x-devfrom
Conversation
james-hill-matomo
approved these changes
Oct 16, 2025
Comment on lines
+471
to
+473
| if (stripos($settingURL, 'index.php') === false) { | ||
| $settingURL .= 'index.php'; | ||
| } |
Contributor
There was a problem hiding this comment.
I spent way too long thinking about this bit. I think the upstream code could be improved!
I'm not 100% sure getPiwikUrl will always include the trailing / either, but I couldn't figure it out for sure!
Contributor
Author
There was a problem hiding this comment.
@james-hill-matomo We have this code for GA and SEKP plugin and its running fine without any errors so I didn't bother adding / check.
Contributor
There was a problem hiding this comment.
We really need a central location for this stuff!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update CustomAlerts to include Matomo domain with idSite
Issue No
#PG-4676
Steps to Replicate the Issue
unique_visitors < 2./console core:run-scheduled-tasks --force "Piwik\Plugins\CustomAlerts\Tasks.runAlertsDaily_{alertID}Checklist