Adds changes to send CustomAlerts via Slack, #PG-4530#8
Merged
AltamashShaikh merged 13 commits into5.x-devfrom Sep 23, 2025
Merged
Adds changes to send CustomAlerts via Slack, #PG-4530#8AltamashShaikh merged 13 commits into5.x-devfrom
AltamashShaikh merged 13 commits into5.x-devfrom
Conversation
snake14
previously approved these changes
Sep 22, 2025
Contributor
There was a problem hiding this comment.
Looks good and posted to the Slack channel as expected 👍
I had a couple nitpick/optional comments. My only other thoughts were:
- It's a bit screenshot heavy. Could any of those screenshots use DOM instead of image comparison?
- It would be good to document the methods with comment blocks, especially the public ones.
snake14
approved these changes
Sep 23, 2025
Contributor
snake14
left a comment
There was a problem hiding this comment.
Thank you for the changes. Adding the comment blocks did highlight how many method parameters aren't typed, but that's probably out of scope.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds changes to send CustomAlerts via Slack
Issue No
#PG-4530
Steps to Replicate the Issue
./console core:run-scheduled-tasks --force "Piwik\Plugins\CustomAlerts\Tasks.runAlertsDaily_{alertID}Checklist