Merge pull request #50 from matomo-org/PG-3334-check-direct-dep

Added tests to check direct use of core dependencies, #PG-3334

Author: AltamashShaikh

.github/workflows/matomo-tests.yml

@@ -32,6 +32,29 @@ concurrency:
   cancel-in-progress: true
 
 jobs:
+  PluginTests:
+    runs-on: ubuntu-20.04
+    strategy:
+      fail-fast: false
+      matrix:
+        php: [ '7.2', '8.2' ]
+        target: ['minimum_required_matomo', 'maximum_supported_matomo']
+    steps:
+      - uses: actions/checkout@v3
+        with:
+          lfs: true
+          persist-credentials: false
+      - name: Install package ripgrep
+        run: sudo apt-get install ripgrep
+      - name: Run tests
+        uses: matomo-org/github-action-tests@main
+        with:
+          plugin-name: 'TreemapVisualization'
+          php-version: ${{ matrix.php }}
+          test-type: 'PluginTests'
+          matomo-test-branch: ${{ matrix.target }}
+          artifacts-pass: ${{ secrets.ARTIFACTS_PASS }}
+          upload-artifacts: ${{ matrix.php == '7.2' && matrix.target == 'maximum_supported_matomo' }}
   UI:
     runs-on: ubuntu-20.04
     steps:
@@ -42,6 +65,7 @@ jobs:
       - name: running tests
         uses: matomo-org/github-action-tests@main
         with:
+          testomatio: ${{secrets.TESTOMATIO}}
           plugin-name: 'TreemapVisualization'
           matomo-test-branch: 'maximum_supported_matomo'
           test-type: 'UI'

tests/System/CheckDirectDependencyUseCommandTest.php

@@ -0,0 +1,53 @@
+<?php
+/**
+ * Copyright (C) InnoCraft Ltd - All rights reserved.
+ *
+ * NOTICE:  All information contained herein is, and remains the property of InnoCraft Ltd.
+ * The intellectual and technical concepts contained herein are protected by trade secret or copyright law.
+ * Redistribution of this information or reproduction of this material is strictly forbidden
+ * unless prior written permission is obtained from InnoCraft Ltd.
+ *
+ * You shall use this code only in accordance with the license agreement obtained from InnoCraft Ltd.
+ *
+ * @link https://www.innocraft.com/
+ * @license For license details see https://www.innocraft.com/license
+ */
+
+namespace Piwik\Plugins\TreemapVisualization\tests\System;
+
+use Piwik\Plugins\TestRunner\Commands\CheckDirectDependencyUse;
+use Piwik\Tests\Framework\TestCase\SystemTestCase;
+use Piwik\Version;
+use Symfony\Component\Console\Input\ArrayInput;
+use Symfony\Component\Console\Output\NullOutput;
+
+class CheckDirectDependencyUseCommandTest extends SystemTestCase
+{
+    public function testCommand()
+    {
+        if (version_compare(Version::VERSION, '5.0.3', '<=') && !file_exists(PIWIK_INCLUDE_PATH . '/plugins/TestRunner/Commands/CheckDirectDependencyUse.php')) {
+            $this->markTestSkipped('tests:check-direct-dependency-use is not available in this version');
+        }
+
+        $pluginName = 'TreemapVisualization';
+        $checkDirectDependencyUse = new CheckDirectDependencyUse();
+
+        $console = new \Piwik\Console(self::$fixture->piwikEnvironment);
+        $console->addCommands([$checkDirectDependencyUse]);
+        $command = $console->find('tests:check-direct-dependency-use');
+        $arguments = [
+            'command'    => 'tests:check-direct-dependency-use',
+            '--plugin' => $pluginName,
+            '--grep-vendor',
+        ];
+
+        $inputObject = new ArrayInput($arguments);
+        $command->run($inputObject, new NullOutput());
+
+        $this->assertEquals([
+            'Symfony\Component\Console' => [
+                'TreemapVisualization/tests/System/CheckDirectDependencyUseCommandTest.php'
+            ],
+        ], $checkDirectDependencyUse->usesFoundList[$pluginName]);
+    }
+}