Skip to content

Add README badges#44

Merged
Kojoley merged 1 commit into
matplotlib:masterfrom
hugovk:patch-1
Dec 20, 2017
Merged

Add README badges#44
Kojoley merged 1 commit into
matplotlib:masterfrom
hugovk:patch-1

Conversation

@hugovk

@hugovk hugovk commented Dec 15, 2017

Copy link
Copy Markdown
Contributor

No description provided.

Comment thread README.rst Outdated
:alt: PyPI Version
:target: https://pypi.python.org/pypi/cycler

.. image:: https://img.shields.io/pypi/pyversions/cycler.svg

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, there is no 3.6, it looks like setup.py needs an update.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will be updated when #43 is merged and released to PyPI.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we have to re-release to pypi to add support for a new version of python? That is a bit annoying...

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version on this badge comes from PyPI, and you don't have to release to PyPI but it is the most common place for Python libraries.

There have been some changes since the last 0.10.0 nearly two years ago: v0.10.0...master

I can remove this badge if you prefer.

@codecov-io

codecov-io commented Dec 16, 2017

Copy link
Copy Markdown

Codecov Report

Merging #44 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #44   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines         177    177           
  Branches       50     50           
=====================================
  Hits          177    177

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5092a6...19eef0e. Read the comment docs.

@hugovk

hugovk commented Dec 20, 2017

Copy link
Copy Markdown
Contributor Author

Is there anything I can do to move this closer to merge?

@Kojoley

Kojoley commented Dec 20, 2017

Copy link
Copy Markdown
Member

Can you please remove merge commits and place the badges to top (for consistency with matplotlib https://github.com/matplotlib/matplotlib/blob/master/README.rst).

@hugovk

hugovk commented Dec 20, 2017

Copy link
Copy Markdown
Contributor Author

Done!

@Kojoley

Kojoley commented Dec 20, 2017

Copy link
Copy Markdown
Member

Nice, thanks!

@Kojoley Kojoley merged commit eaa0f63 into matplotlib:master Dec 20, 2017
@hugovk hugovk deleted the patch-1 branch December 20, 2017 13:29
@QuLogic QuLogic added this to the v1.0 milestone Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants