Cleanups#61
Merged
Merged
Conversation
The `concat` method can just directly reuse the free function definition. (Also using string-joining was a bit overkill.) Inlining `_compose` into `__iter__` (its sole user) seems easier to follow than having it defined nearly 50 lines away).
timhoffm
reviewed
Feb 9, 2021
timhoffm
left a comment
timhoffm
left a comment
Member
There was a problem hiding this comment.
The changes are intended to make the concat docstring match both the function and the method as good as possible.
Punctuation. Use "cycler" instead of "Cycler" or "cycle" in sentences
slightly more consistently. Remove parameter descriptions that add no
information ("the second Cycler"). Remove unnecessary whitespace.
Contributor
Author
|
yup, all agreed. |
timhoffm
approved these changes
Feb 10, 2021
QuLogic
approved these changes
Apr 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First commit: Don't dupe concat() definition; inline _compose().
The
concatmethod can just directly reuse the free functiondefinition. (Also using string-joining was a bit overkill.)
Inlining
_composeinto__iter__(its sole user) seems easier tofollow than having it defined nearly 50 lines away).
Second commit: Minor doc cleanups.
Punctuation. Use "cycler" instead of "Cycler" or "cycle" in sentences
slightly more consistently. Remove parameter descriptions that add no
information ("the second Cycler"). Remove unnecessary whitespace.