JupyterLite support#14
Conversation
JupyterLite support
|
|
| ax1.plot(datetime, solar, label='hourly') | ||
| ax1.plot(datetime, solar_low, label='smoothed') | ||
| ax1.legend(loc='upper right') | ||
| ax1.set_ylabel('Solar radiation $[W\,m^{-2}]$') # note the use of TeX math formatting |
There was a problem hiding this comment.
This needs escaping/raw string:
<>:13: SyntaxWarning: invalid escape sequence '\,'
/tmp/xpython_42/3616412460.py:13: SyntaxWarning: invalid escape sequence '\,'
ax1.set_ylabel('Solar radiation $[W\,m^{-2}]$') # note the use of TeX math formatting
| ax0.set_xlabel('Solar Radiation $[W\,m^{-2}]$') | ||
| ax0.set_ylabel('Temperature $[^oC]$') | ||
| ax0.set_title('Hourly', loc='left') | ||
|
|
||
|
|
||
| ax1.set_facecolor('0.6') | ||
| sc = ax1.scatter(solar_low[::24], temp_low[::24], c=dayofyear[::24], s=4, cmap='RdBu_r') | ||
| ax1.set_xlabel('Solar Radiation $[W\,m^{-2}]$') |
There was a problem hiding this comment.
More escaping:
<>:5: SyntaxWarning: invalid escape sequence '\,'
<>:12: SyntaxWarning: invalid escape sequence '\,'
/tmp/xpython_42/4276427300.py:5: SyntaxWarning: invalid escape sequence '\,'
ax0.set_xlabel('Solar Radiation $[W\,m^{-2}]$')
/tmp/xpython_42/4276427300.py:12: SyntaxWarning: invalid escape sequence '\,'
ax1.set_xlabel('Solar Radiation $[W\,m^{-2}]$')
There was a problem hiding this comment.
Why is this added? This branch isn't published on GitHub Pages.
There was a problem hiding this comment.
Why do we still need these files if you've moved them to content? Or do we even need content?
| @@ -1,11 +1,9 @@ | |||
| name: mpl_brochure_binder | |||
| name: xeus-kernel | |||
|
|
||
| Try it in your browser (no installation required): | ||
|
|
||
| [](https://matplotlib.github.io/mpl-brochure-binder/lab/index.html?path=MatplotlibExample.ipynb) |
There was a problem hiding this comment.
We don't use GitHub Pages URLs; this link is broken.
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v4 |
There was a problem hiding this comment.
This (and all other actions) is outdated, and should use SHA hashes instead of rolling tags.
| cache-environment: true | ||
|
|
||
| - name: Build the JupyterLite site | ||
| shell: bash -l {0} |
There was a problem hiding this comment.
Should keep the error check
| shell: bash -l {0} | |
| shell: bash -e -l {0} |
|
|
||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Deploy to GitHub Pages |
There was a problem hiding this comment.
We don't use GitHub Pages, so this deployment is not necessary. You should push the results to the gh-pages branch instead (probably overwriting any existing commit.)
story645
dismissed
their stale review
Apparently don't know enough about the deployment, was just basing on it working
|
Note, if we need to publish this on the website instead of loading the repo itself through binder, it will need to be added to the |
3 participants
For matplotlib/mpl-brochure-site#112
Live version: https://jtpio.github.io/mpl-brochure-binder/lab/index.html?path=MatplotlibExample.ipynb
For this to work on this repo you will need to enable GitHub Pages as follows:
changes
np.nancontent